refactor(chat): migrate chat.getThreadsList to typed REST endpoint

apps/meteor/app/api/server/v1/chat.ts

@@ -275,6 +275,38 @@ const isChatPinMessageProps = ajv.compile<ChatPinMessage>(ChatPinMessageSchema);
 
 const isChatUnpinMessageProps = ajv.compile<ChatUnpinMessage>(ChatUnpinMessageSchema);
 
+const isChatGetThreadsListResponse = ajv.compile<{
+	threads: IMessage[];
+	count: number;
+	offset: number;
+	total: number;
+}>({
+	type: 'object',
+	properties: {
+		threads: {
+			type: 'array',
+			items: {
+				type: 'object',
+			},
+		},
+		count: {
+			type: 'number',
+		},
+		offset: {
+			type: 'number',
+		},
+		total: {
+			type: 'number',
+		},
+		success: {
+			type: 'boolean',
+			enum: [true],
+		}
+	},
+	required: ['threads', 'count', 'offset', 'total', 'success'],
+	additionalProperties: false,
+});
+
 const chatEndpoints = API.v1
 	.post(
 		'chat.pinMessage',
@@ -558,6 +590,58 @@ const chatEndpoints = API.v1
 
 			return API.v1.success();
 		},
+	)
+	.get(
+		'chat.getThreadsList',
+		{
+			authRequired: true,
+			validateParams: isChatGetThreadsListProps,
+			response: {
+				400: validateBadRequestErrorResponse,
+				401: validateUnauthorizedErrorResponse,
+				200: isChatGetThreadsListResponse,
+			},
+		},
+		async function action() {
+			const { rid, type, text } = this.queryParams;
+
+			const { offset, count } = await getPaginationItems(this.queryParams);
+			const { sort, fields, query } = await this.parseJsonQuery();
+
+			if (!settings.get<boolean>('Threads_enabled')) {
+				throw new Meteor.Error('error-not-allowed', 'Threads Disabled');
+			}
+			const user = await Users.findOneById(this.userId, { projection: { _id: 1 } });
+			const room = await Rooms.findOneById(rid, { projection: { ...roomAccessAttributes, t: 1, _id: 1 } });
+
+			if (!room || !user || !(await canAccessRoomAsync(room, user))) {
+				throw new Meteor.Error('error-not-allowed', 'Not Allowed');
+			}
+
+			const typeThread = {
+				_hidden: { $ne: true },
+				...(type === 'following' && { replies: { $in: [this.userId] } }),
+				...(type === 'unread' && { _id: { $in: (await Subscriptions.findOneByRoomIdAndUserId(room._id, user._id))?.tunread || [] } }),
+				msg: new RegExp(escapeRegExp(text || ''), 'i'),
+			};
+
+			const threadQuery = { ...query, ...typeThread, rid: room._id, tcount: { $exists: true } };
+			const { cursor, totalCount } = await Messages.findPaginated<IThreadMainMessage>(threadQuery, {
+				sort: sort || { tlm: -1 },
+				skip: offset,
+				limit: count,
+				projection: fields,
+			});
+
+			const [threads, total] = await Promise.all([cursor.toArray(), totalCount]);
+
+			return API.v1.success({
+				threads: await normalizeMessagesForUser(threads, this.userId),
+				count: threads.length,
+				offset,
+				total,
+			});
+		},
 	);
 
 API.v1.addRoute(
@@ -782,52 +866,6 @@ API.v1.addRoute(
 	},
 );
 
-API.v1.addRoute(
-	'chat.getThreadsList',
-	{ authRequired: true, validateParams: isChatGetThreadsListProps },
-	{
-		async get() {
-			const { rid, type, text } = this.queryParams;
-
-			const { offset, count } = await getPaginationItems(this.queryParams);
-			const { sort, fields, query } = await this.parseJsonQuery();
-
-			if (!settings.get<boolean>('Threads_enabled')) {
-				throw new Meteor.Error('error-not-allowed', 'Threads Disabled');
-			}
-			const user = await Users.findOneById(this.userId, { projection: { _id: 1 } });
-			const room = await Rooms.findOneById(rid, { projection: { ...roomAccessAttributes, t: 1, _id: 1 } });
-
-			if (!room || !user || !(await canAccessRoomAsync(room, user))) {
-				throw new Meteor.Error('error-not-allowed', 'Not Allowed');
-			}
-
-			const typeThread = {
-				_hidden: { $ne: true },
-				...(type === 'following' && { replies: { $in: [this.userId] } }),
-				...(type === 'unread' && { _id: { $in: (await Subscriptions.findOneByRoomIdAndUserId(room._id, user._id))?.tunread || [] } }),
-				msg: new RegExp(escapeRegExp(text || ''), 'i'),
-			};
-
-			const threadQuery = { ...query, ...typeThread, rid: room._id, tcount: { $exists: true } };
-			const { cursor, totalCount } = await Messages.findPaginated<IThreadMainMessage>(threadQuery, {
-				sort: sort || { tlm: -1 },
-				skip: offset,
-				limit: count,
-				projection: fields,
-			});
-
-			const [threads, total] = await Promise.all([cursor.toArray(), totalCount]);
-
-			return API.v1.success({
-				threads: await normalizeMessagesForUser(threads, this.userId),
-				count: threads.length,
-				offset,
-				total,
-			});
-		},
-	},
-);
 
 API.v1.addRoute(
 	'chat.syncThreadsList',