Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #39845 +/- ##
===========================================
- Coverage 70.50% 70.36% -0.15%
===========================================
Files 3270 3271 +1
Lines 116778 117080 +302
Branches 21105 21141 +36
===========================================
+ Hits 82340 82385 +45
- Misses 32383 32621 +238
- Partials 2055 2074 +19
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@KevLehman can you add a |
|
/layne exception-approve LAYNE-92cc1dd60a09a52c LAYNE-f3b98cfa0ce32ac8 reason: Kevin justified that the 2 instances of ignoreSsrfValidation are actually only configured by a workspace admin |
|
✅ Exception recorded for LAYNE-92cc1dd60a09a52c, LAYNE-f3b98cfa0ce32ac8 by @julio-rocketchat: "Kevin justified that the 2 instances of ignoreSsrfValidation are actually only configured by a workspace admin". Re-running scan... |
5000d66 to
65f09e0
Compare
This reverts commit b29fb86.
65f09e0 to
7d82278
Compare
|
/layne exception-approve LAYNE-fa31c7e349286e51 LAYNE-67d67ea80c17baca LAYNE-955f7ddec71ff37f reason: same as before, only configurable by admins |
|
✅ Exception recorded for LAYNE-fa31c7e349286e51, LAYNE-67d67ea80c17baca, LAYNE-955f7ddec71ff37f by @julio-rocketchat: "same as before, only configurable by admins". Re-running scan... |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/CORE-2018