Skip to content

feat: External PDP#39845

Draft
KevLehman wants to merge 31 commits intodevelopfrom
feat/externalpdp
Draft

feat: External PDP#39845
KevLehman wants to merge 31 commits intodevelopfrom
feat/externalpdp

Conversation

@KevLehman
Copy link
Copy Markdown
Member

@KevLehman KevLehman commented Mar 24, 2026

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/CORE-2018

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Mar 24, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2026

⚠️ No Changeset found

Latest commit: e8a0abb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 23db2187-61c4-4f43-905a-dd74b4bec865

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 25.99388% with 242 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.36%. Comparing base (8a30bfb) to head (e8a0abb).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #39845      +/-   ##
===========================================
- Coverage    70.50%   70.36%   -0.15%     
===========================================
  Files         3270     3271       +1     
  Lines       116778   117080     +302     
  Branches     21105    21141      +36     
===========================================
+ Hits         82340    82385      +45     
- Misses       32383    32621     +238     
- Partials      2055     2074      +19     
Flag Coverage Δ
e2e 60.41% <ø> (-0.04%) ⬇️
e2e-api 49.04% <ø> (+0.97%) ⬆️
unit 70.74% <25.99%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rc-layne
Copy link
Copy Markdown

rc-layne bot commented Mar 24, 2026

⚠️ Layne — 5 warning(s)

Found 5 issue(s): 5 high.

@julio-rocketchat
Copy link
Copy Markdown
Member

🔴 Layne — 2 finding(s)

Found 2 issue(s): 2 high.

@KevLehman can you add a // SECURITY: <reason> comment on top of each ignoreSsrfValidation: true or on the same line? Then I can approve Layne's findings as exceptions so that the check passes.

@julio-rocketchat
Copy link
Copy Markdown
Member

/layne exception-approve LAYNE-92cc1dd60a09a52c LAYNE-f3b98cfa0ce32ac8 reason: Kevin justified that the 2 instances of ignoreSsrfValidation are actually only configured by a workspace admin

@rc-layne
Copy link
Copy Markdown

rc-layne bot commented Mar 25, 2026

✅ Exception recorded for LAYNE-92cc1dd60a09a52c, LAYNE-f3b98cfa0ce32ac8 by @julio-rocketchat: "Kevin justified that the 2 instances of ignoreSsrfValidation are actually only configured by a workspace admin". Re-running scan...

Base automatically changed from chore/abac-strategy to develop March 31, 2026 18:03
@julio-rocketchat
Copy link
Copy Markdown
Member

/layne exception-approve LAYNE-fa31c7e349286e51 LAYNE-67d67ea80c17baca LAYNE-955f7ddec71ff37f reason: same as before, only configurable by admins

@rc-layne
Copy link
Copy Markdown

rc-layne bot commented Apr 6, 2026

✅ Exception recorded for LAYNE-fa31c7e349286e51, LAYNE-67d67ea80c17baca, LAYNE-955f7ddec71ff37f by @julio-rocketchat: "same as before, only configurable by admins". Re-running scan...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants