feat(uikit): add room to some other interaction contexts#39858
Draft
feat(uikit): add room to some other interaction contexts#39858
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 18c29d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
12 tasks
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com> Agent-Logs-Url: https://github.com/RocketChat/Rocket.Chat/sessions/1d9fe17e-f376-436c-a62e-97a42942ac9e
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com> Agent-Logs-Url: https://github.com/RocketChat/Rocket.Chat/sessions/1d9fe17e-f376-436c-a62e-97a42942ac9e
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com> Agent-Logs-Url: https://github.com/RocketChat/Rocket.Chat/sessions/9124b5cb-6821-4135-a3ed-9ac62f9f0d24
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com> Agent-Logs-Url: https://github.com/RocketChat/Rocket.Chat/sessions/4fce8021-7e0b-4eb1-8658-47de2f9629be
- Enhanced test app to support modal, contextual bar, and message surfaces - Added getAppLogs helper to e2e fixtures for fetching app logs - Updated installLocalTestPackage to return app data - Completed all 7 Playwright test cases validating room, user, triggerId, actionId, and container - Removed old non-applicable end-to-end test (uikit-room-context.ts) - Updated README documentation for the enhanced test app Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com> Agent-Logs-Url: https://github.com/RocketChat/Rocket.Chat/sessions/ec71feb5-1416-4b80-8e2f-b03c571ccef4
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com> Agent-Logs-Url: https://github.com/RocketChat/Rocket.Chat/sessions/ec71feb5-1416-4b80-8e2f-b03c571ccef4
Opening a contextual bar via the Apps Engine triggers a client-side
URL navigation (to /channel/{room}/app/{viewId}). Calling waitFor on
a locator while this navigation is still in progress causes Playwright
to throw "Target page, context or browser has been closed".
Add page.waitForURL(/\/app\//) after dispatching the contextual bar
slash command in all three contextual bar tests to ensure the
navigation completes before any locator operations.
Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
Agent-Logs-Url: https://github.com/RocketChat/Rocket.Chat/sessions/1998ca62-abf1-478a-835c-d3ea1053d273
d-gubert
force-pushed
the
fix/uikit-interaction-room-data
branch
from
4c13525 to
18c29d2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #39858 +/- ##
===========================================
- Coverage 70.55% 70.52% -0.03%
===========================================
Files 3271 3271
Lines 116782 116781 -1
Branches 21090 21040 -50
===========================================
- Hits 82393 82361 -32
- Misses 32338 32362 +24
- Partials 2051 2058 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This pull request enhances the contextual bar UI Kit integration by ensuring the room ID (rid) is consistently included and handled throughout the UI interaction flow. This allows the backend to associate UI Kit interactions with the correct room context, enabling more context-aware app behaviors.
Issue(s)
CORE-1264
Steps to test or reproduce
Further comments