Skip to content

feat(googlephotos): add custom branding patch#21

Open
vancedto wants to merge 2 commits into
RookieEnough:mainfrom
vancedto:main
Open

feat(googlephotos): add custom branding patch#21
vancedto wants to merge 2 commits into
RookieEnough:mainfrom
vancedto:main

Conversation

@vancedto

Copy link
Copy Markdown

Add a new resource-only patch that rebrands Google Photos:

  • Renames the app to "ReVanced Google Photos"
  • Replaces the launcher icon with a bundled custom PNG

Manifest patching covers three layers to ensure the launcher and app drawer both reflect the new branding:

  1. android:label and android:icon
  2. Any carrying the LAUNCHER intent filter
  3. Any carrying the LAUNCHER intent filter

Icon replacement is done in two passes:

  • Copy bundled PNGs as a new resource (morphe_photos_launcher) into all mipmap-{mdpi,hdpi,xhdpi,xxhdpi,xxxhdpi} directories
  • Overwrite the original launcher icon files with the same PNGs so the splash screen (which references the original resource name internally) also shows the new icon

Add a new resource-only patch that rebrands Google Photos:
- Renames the app to "ReVanced Google Photos"
- Replaces the launcher icon with a bundled custom PNG

Manifest patching covers three layers to ensure the launcher
and app drawer both reflect the new branding:
  1. <application> android:label and android:icon
  2. Any <activity-alias> carrying the LAUNCHER intent filter
  3. Any <activity> carrying the LAUNCHER intent filter

Icon replacement is done in two passes:
  - Copy bundled PNGs as a new resource (morphe_photos_launcher)
    into all mipmap-{mdpi,hdpi,xhdpi,xxhdpi,xxxhdpi} directories
  - Overwrite the original launcher icon files with the same PNGs
    so the splash screen (which references the original resource
    name internally) also shows the new icon
@Akash-Sriram

Copy link
Copy Markdown

Could use morphe google photo

@RookieEnough

Copy link
Copy Markdown
Owner

Thanks for the PR man, but De-Vanced patches are for Morphe, not ReVanced. So custom rebranding into Revanced doesn't sound right.

@NoelJacob

Copy link
Copy Markdown
image How does this look. Negative image of icon. Fits with the revanced/morphe theme of having primarily dark icons.

@Algiuxs Algiuxs left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change to Morphe from revanced

import org.w3c.dom.Element

private const val ICON_RESOURCE_NAME = "morphe_photos_launcher"
private const val APP_NAME = "ReVanced Google Photos"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs to be:

Suggested change
private const val APP_NAME = "ReVanced Google Photos"
private const val APP_NAME = "Morphe Google Photos"

Or

Suggested change
private const val APP_NAME = "ReVanced Google Photos"
private const val APP_NAME = "Morphe Photos"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants