Fix an overflow in Streebog causing panic or incorrect output#91
Merged
Conversation
Member
|
Thank you! I will add a test vector for this bug and will publish a release ASAP. Later I will also add an appropriate advisory to the RustSec DB. There is also an opportunity to improve performance a bit by using addition over 32-bit number in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the
update_sigmafunction of Streebog.For example for the input consisting of 96 bytes of 255 (0xFF), current crate either panics:
Or produces an incorrect output:
Compare output with OpenSSL using the GOST engine:
Due to poor specification and missing KATs a number of other impls have run into similar issues
gpg/libgcrypt@da6cd4f