Release script improvements#8641
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the release script to use the specific version tag instead of HEAD when generating release notes. A review comment identifies that while the pull request description mentions a new dependency on jq, the corresponding prerequisite check is missing from the script, which could lead to runtime failures.
pbrezina
changed the title
pbrezina
changed the title
|
/gemini The contents of this PR has changed dramatically. Re-review. |
There was a problem hiding this comment.
Code Review
This pull request enhances the release automation scripts by introducing automatic stable branch creation and backport label generation when releasing from the master branch. It also refines the version calculation logic and ensures release notes are generated against specific version tags rather than the HEAD. Review feedback highlighted a bug in the version calculation for major releases (X.0.0) and suggested making the label creation step idempotent to prevent script failures on re-runs.
While HEAD is identical to VERSION (version tag == HEAD), we want to use the tag identifier to show it in the release notes in the git shortlog command.
|
/gemini review again, I fixed your comments |
There was a problem hiding this comment.
Code Review
This pull request automates several steps in the release process, including the calculation of previous versions, determination of stable branch names, and the creation of backport labels. It also updates the release notes template with instructions for contributors on using suggestions and squashing commits. Review feedback identifies a potential bug in label existence checking due to substring matching and suggests refactoring a dense conditional to improve code readability.
|
/gemini review again, I fixed your comments |
There was a problem hiding this comment.
Code Review
This pull request automates several steps in the release process, including the determination of the previous version tag, the creation of stable branches, and the generation of backport labels. It also adds instructional tips to the release notes template. Feedback was provided to improve the version detection logic for minor releases, add validation for the detected previous version, and ensure all tags are fetched to prevent issues in environments with shallow checkouts.
Instead of requiring the previous version as a parameter, derive it from the release version: X.Y.0 → X.(Y-1).0, X.Y.Z → X.Y.(Z-1).
When releasing from master, automatically create the sssd-X-Y stable branch from the release tag and a backport-to-sssd-X-Y GitHub label.
Add a workflow_dispatch choice parameter (auto/no) to control whether a stable branch and backport label are created. Default "auto" creates them only when releasing from master.
Use the git_remote variable instead of hardcoded "origin" to be consistent with the push commands.
If this step fails, we ensure that no changes were pushed so far.
|
/gemini review again, I fixed your comments |
There was a problem hiding this comment.
Code Review
This pull request automates several release tasks, such as calculating the previous version, creating stable branches, and setting up backport labels. It also updates documentation to encourage the use of GitHub suggestions. Feedback indicates that the logic for determining the previous version is fragile and should instead rely on querying existing tags. Furthermore, the script should ensure tags are fetched before attempting to identify the previous version to avoid using stale data.
3 participants
Few commits to simplify the release process - automate even more things.