Conversation
GonzaloGM
changed the title
Record the AnnouncementService survivor clusters, root causes, and the new tests that pin default options, active-only filtering, and stale-device skip behavior.
Add behavior-level tests for invalid-item skipping, deterministic support path shape, and attachment metadata normalization including MIME fallback and integer size.
Record survivor causes for attachment iteration and metadata normalization, and map each targeted mutant ID to the new behavior-focused tests.
Add behavior-focused tests for default max-size fallback, numeric max-size casting, and preservation of the primary type error when extension and size checks also fail.
Record the surviving validator mutant causes and the new tests that pin max-size fallback/casting and error-message precedence semantics.
Add behavior-level tests for trip eligibility filters, passenger deduplication, and canceled-request exclusion to pin observable rating generation outcomes.
Record survivor causes and targeted tests for trip eligibility, canceled-state handling, and duplicate-passenger rating constraints.
Add behavior-focused tests for provider setup, update validation rules, image preservation for linked users, and value-based ownership checks across string/int social ids.
Document surviving SocialManager mutation causes and the new behavior-level tests that pin provider setup, ownership checks, and existing-image handling.
Add a behavior-focused test ensuring self-reference rejection works for equivalent int/string user ids, preserving value-based guard semantics.
Capture the surviving equality mutant cause in the self-reference guard and the new test that enforces value-based id comparison behavior.
Add behavior-focused tests for address validation, optional-field duplicate detection, ownership checks across scalar ids, and delete/update failure branches.
Record mutant root causes and new tests covering validation rules, duplicate matching for optional fields, ownership semantics, and delete/update failure behavior.
Add behavior-focused tests for default title assignment, invalid trip-id normalization, existing-conversation trip-id updates, and admin trip-conversation retrieval.
Capture remaining trip-thread mutant causes and the tests that pin title defaults, trip-id normalization, and admin retrieval behavior.
Add behavior-focused tests for duplicate payload details, scoped update uniqueness, update validation failures, scalar-equivalent ownership checks, and delete-failure handling.
Record mutant causes and the new tests that pin duplicate error payloads, scoped uniqueness, owner checks, and delete/update failure branches.
Add behavior-focused tests ensuring pending friendship edges are cleared correctly during request, accept, reject, and make transitions.
Describe the surviving cleanup mutants and the new transition tests that pin pending-edge deletion behavior.
Add behavior-focused tests for send/resend validation, blocked verification states, and resend cooldown rejection contracts.
Capture the remaining guard-branch mutant causes and the tests that pin blocked and cooldown verification behavior.
Add a behavior-focused fixture test that drives the short-segment fallback thresholds and asserts route-node attachment plus processed state.
Record the uncovered fallback-threshold branch behavior and the new test that constrains route matching outcomes.
Add behavior-focused TripsManager tests for verified-driver gating and user banning when trip creation limits, banned words, or banned phone checks are triggered.
Record the uncovered create-time guard branches, why they survived, and which new tests plus mutant IDs are now covered.
Add behavior-driven tests for invalid notification validation, session update short-circuit behavior, and scalar-equivalent ownership checks in update/delete.
Capture why DeviceManager mutants survived and the new behavior-focused tests that now cover validation, ownership equality, and session short-circuit behavior.
Add behavioral tests for invalid-input early stop and unanswered-message-limit rejection so no request row or events are emitted on blocked flows.
Record the surviving newRequest guard mutants, why they survived, and the behavior-focused tests added to lock the expected error contracts and side effects.
Pin getUserData log concatenation and name assembly for social login.
Inject Guzzle client; assert 200 mapping, errors, birthday transform, and FACEBOOK BODY logging.
…viders Document Infection mutant IDs, causes, and fixes for the Apr 2026 report.
Record Log::error calls during Android send failure and assert outer send() catch context (user, device, redacted token, type, trace) plus inner sendAndroid catch (input_data). Add tests for missing toPush and missing getExtras. Document killed Infection mutants in mutation-notes.
…ut_data Add outer-log coverage for browser Firebase failures, inner+outer logs when APNs certificate path is missing, and assert sendAndroid error input_data preserves type/url/image and getExtras merge. Document mutant groups in mutation-notes.
Inject Guzzle client and assert Graph URL, image persistence, trip filter, and MessageLogged for COMMAND FacebookImage. Document mutant IDs in tests/mutation-notes.md.
Kills RemoveMethodCall mutants on COMMAND RatesAvailability logging; notes list mutant ID aa95f328bc5c911b in tests/mutation-notes.md.
Mock AnnouncementService to assert banner, stats, dry-run, rate limit, success and failure result lines. Document mutant IDs in tests/mutation-notes.md.
Create minimal failed_jobs schema in tests and assert the cleanup info line only when deletes occur. Document mutant IDs in tests/mutation-notes.md.
- DownloadPoints: injectable GoogleDirection, strict count check, tests for log and skip past trips - EmailMessageNotification: eager-load conversation to avoid lazy load on save - updateTrips: typed deps, parent::__construct before assignment - Tests: MessageLogged/COMMAND assertions, edge cases for remainder, trip hours, badges, tickets, anonymize output - Document mutant causes and fixes in tests/mutation-notes.md
Assert MessageLogged COMMAND RequestNotAnswer and preventLazyLoading so with(['user','trip']) cannot be removed without failing (Infection mutants 50ff0ce9e9922e9c, 97cd516bcb7e4a65, 3b7ca2c9f8e9fb59, a64b13e501fc488a).
MessageLogged for COMMAND and Route builder; createRoute receives origin and destiny loaded; second trip on another route ensures whereHas route id filter; MessageLogged on createRoute failure (Infection mutants df8ccc6bafb062ea through afd774f01999bd94).
MessageLogged for COMMAND GenerateTripVisibility (mutant ae1e0d385a2622e2).
Strengthen --user-id success output assertions; auto-pick user path with inactive distractor; sendToUser failure error prefix (Infection cluster on TestAnnouncement.php).
Dry-run display lines and no Badges awarded line; empty user-ids filter; confirm-yes non-dry path through displayResults (EvaluateBadges.php mutants).
Replace exit(1) with InvalidArgumentException caught in handle for invalid or disallowed months; catch Carbon parse errors; assert dry-run lines, saved_at, and MessageLogged on save (CalculateActiveUsersPerMonth.php mutants).
…ctive Append mutation-notes for the latest Infection hardening batch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage reporting and initial test suite