Skip to content

feat(schemas/github-action): support composite run steps#1183

Merged
madskristensen merged 2 commits intoSchemaStore:masterfrom
ngraef:github-action-composite-run
Aug 10, 2020
Merged

feat(schemas/github-action): support composite run steps#1183
madskristensen merged 2 commits intoSchemaStore:masterfrom
ngraef:github-action-composite-run

Conversation

@ngraef
Copy link
Copy Markdown
Contributor

@ngraef ngraef commented Aug 7, 2020

This PR updates the github-action json schema with support for the new composite run steps and pre*/post* scripts. It also updates all $comment links to GitHub's new docs site.

@madskristensen madskristensen merged commit 45acb7a into SchemaStore:master Aug 10, 2020
@madskristensen
Copy link
Copy Markdown
Contributor

Thanks

@amis92
Copy link
Copy Markdown

amis92 commented Aug 20, 2020

I'm not sure who's the "owner" of this file, and if there's any - but I found, when building my composite action, that outputs.<output-id>.value is not recognized.

This property is documented at https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#outputs-for-composite-run-steps-actions

I'd gladly make a PR, but I don't really know much about json schemas, and I'm not sure how to link using: composite with outputs, as they are in different "root" properties.

@madskristensen
Copy link
Copy Markdown
Contributor

@ngraef any tips regarding implementing the behavior @amis92 is mentioning? Sounds like a bug in the schema

@ngraef
Copy link
Copy Markdown
Contributor Author

ngraef commented Aug 20, 2020

Thanks for pointing that out, @amis92. I can get the schema updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants