Skip to content

Fix Codeowners Merge workflow to run on more events#5572

Merged
hyperupcall merged 1 commit intomasterfrom
hyperupcall-codeownersmerge-undraft
Apr 12, 2026
Merged

Fix Codeowners Merge workflow to run on more events#5572
hyperupcall merged 1 commit intomasterfrom
hyperupcall-codeownersmerge-undraft

Conversation

@hyperupcall
Copy link
Copy Markdown
Member

@hyperupcall hyperupcall commented Apr 12, 2026

This closes #5567.

In PRs like #5566, if a pull request is submitted as a draft, The codeowners workflow isn't ran (expected behavior) since draft's aren't ready. It's defined like so:

jobs:
  codeowners-merge:
    if: "github.repository == 'SchemaStore/schemastore' && github.event.pull_request.draft == false"

However, if the pull request is then marked as ready for review, the codeowners merge workflow still isn't ran. This updates the event hooks so that it is ran afterwards. It now is also ran after the pull request is re-opened, which fixes a similar bug.

Verified the fix in #5573.

@github-actions github-actions bot added the CI ".github/**/*" folder is updated (auto-generated by labeler action) label Apr 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall hyperupcall merged commit 9857657 into master Apr 12, 2026
7 checks passed
@hyperupcall hyperupcall deleted the hyperupcall-codeownersmerge-undraft branch April 12, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI ".github/**/*" folder is updated (auto-generated by labeler action)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The maintainer isn't receiving mentions.

1 participant