Skip to content
This repository was archived by the owner on Jan 27, 2020. It is now read-only.

Add VCFtools#568

Merged
szilvajuhos merged 9 commits intoSciLifeLab:masterfrom
maxulysse:vcftools
Apr 16, 2018
Merged

Add VCFtools#568
szilvajuhos merged 9 commits intoSciLifeLab:masterfrom
maxulysse:vcftools

Conversation

@maxulysse
Copy link
Copy Markdown
Member

@maxulysse maxulysse commented Apr 13, 2018

close #368

  • New vcftools container
  • New RunVcftools process
  • Update output from ConcatVCF process
  • Actually use all VCFs in the reports

Copy link
Copy Markdown
Collaborator

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These is still mutect1 at many places, but I guess these are going to disappear with #567

Comment thread buildContainers.nf
log.info " all, fastqc, freebayes, gatk, igvtools, multiqc, mutect1"
log.info " picard, qualimap, r-base, runallelecount, sarek"
log.info " snpeff, snpeffgrch37, snpeffgrch38, vepgrch37, vepgrch38"
log.info " picard, qualimap, r-base, runallelecount, sarek, snpeff"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have fastqc, multiqc, qualimap, vcftools, as separate containers: these are all QC tools, is it possible to keep them separate, or can we merge these containers sometime?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be a good idea, I'll think about it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread buildContainers.nf
@@ -211,8 +212,8 @@ def helpMessage() {
log.info " Default: all"
log.info " Possible values:"
log.info " all, fastqc, freebayes, gatk, igvtools, multiqc, mutect1"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be mutect2 I guess

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, mutect2 is shipped with the GATK container

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IC, of course. Shall I merge this first, or shall I wait for #567 ?

@maxulysse
Copy link
Copy Markdown
Member Author

Yes, removing mutect1 is another PR

@szilvajuhos szilvajuhos merged commit 3fc8560 into SciLifeLab:master Apr 16, 2018
@maxulysse maxulysse deleted the vcftools branch April 16, 2018 09:01
jherrero referenced this pull request in UCL-BLIC/Sarek_v2.2.1 Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add vcftools vcf-stats for vcf

2 participants