Skip to content
This repository was archived by the owner on Jan 27, 2020. It is now read-only.

Binac addition#596

Merged
maxulysse merged 4 commits intoSciLifeLab:masterfrom
KochTobi:binac_addition
Jun 7, 2018
Merged

Binac addition#596
maxulysse merged 4 commits intoSciLifeLab:masterfrom
KochTobi:binac_addition

Conversation

@KochTobi
Copy link
Copy Markdown
Collaborator

@KochTobi KochTobi commented Jun 6, 2018

Added the configuration for the german BinAC cluster.

@maxulysse
Copy link
Copy Markdown
Member

That's a nice PR.
I believe you might need to import as well a singularity config file.

singularity.conf
containers.conf
@KochTobi
Copy link
Copy Markdown
Collaborator Author

KochTobi commented Jun 7, 2018

Thanks :)
I have now added the singularity.conf and the containers.conf in the nextflow.conf.
Was that correct?

@maxulysse
Copy link
Copy Markdown
Member

Yes, definitively, I forgot to mention it.
Your PR seems totally fine.
Just waiting for the tests to finish and I'll merge it.

@maxulysse maxulysse self-requested a review June 7, 2018 08:45
@maxulysse maxulysse self-assigned this Jun 7, 2018
@maxulysse maxulysse merged commit 90acb6e into SciLifeLab:master Jun 7, 2018
@KochTobi KochTobi deleted the binac_addition branch December 2, 2018 14:43
jherrero referenced this pull request in UCL-BLIC/Sarek_v2.2.1 Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants