Skip to content
This repository was archived by the owner on Jan 27, 2020. It is now read-only.

To process targeted sequencing with a target BED#635

Merged
maxulysse merged 36 commits intoSciLifeLab:devfrom
szilvajuhos:master
Sep 21, 2018
Merged

To process targeted sequencing with a target BED#635
maxulysse merged 36 commits intoSciLifeLab:devfrom
szilvajuhos:master

Conversation

@szilvajuhos
Copy link
Copy Markdown
Collaborator

@szilvajuhos szilvajuhos commented Sep 6, 2018

Changes to make possible to add a BED file and run targeted processing for both germline and somatic calls. To be tested on real WES data.

PR checklist

  • PR is made against dev branch
  • PR is a hotfix against master branch
  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/SciLifeLab/Sarek/blob/master/.github/CONTRIBUTING.md

Comment thread germlineVC.nf Outdated
concatOptions = "-i ${genomeIndex} -c ${task.cpus} -o ${outputFile} "

"""
${workflow.projectDir}/scripts/concatenateVCFs.sh ${concatOptions}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put the new concatenateVCFs.sh script in bin instead, it's directly in the $PATH

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks, I am still testing, but will move

@maxulysse
Copy link
Copy Markdown
Member

I noticed that you updated Sarek-data as well, don't forget to update the submodule in Sarek as well

Comment thread scripts/wrapper.sh Outdated
echo "$(tput setaf 1)nextflow run $@ -profile $PROFILE --genome $GENOME --genome_base $GENOMEBASE --tag $TAG --verbose$(tput sgr0) --max_cpus ${CPUS}"
nextflow run $@ -profile $PROFILE --genome $GENOME --genome_base $GENOMEBASE --tag $TAG --verbose --max_cpus ${CPUS}
else
echo "$(tput setaf 1)nextflow run $@ -profile $PROFILE --genome $GENOME --genome_base $GENOMEBASE --tag $TAG --verbose$(tput sgr0) --max_cpus ${CPUS}" --targetBED ${TARGETBED}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be

echo "$(tput setaf 1)nextflow run $@ -profile $PROFILE --genome $GENOME --genome_base $GENOMEBASE --tag $TAG --verbose$(tput sgr0) --max_cpus ${CPUS} --targetBED ${TARGETBED}"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo with the "

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread README.md
Comment thread CHANGELOG.md Outdated
- [#620](https://github.com/SciLifeLab/Sarek/pull/620) - Add `tmp/` to `.gitignore`
- [#625](https://github.com/SciLifeLab/Sarek/pull/625) - Add [`pathfindr`](https://github.com/NBISweden/pathfindr) as a submodule
- [#639](https://github.com/SciLifeLab/Sarek/pull/639) - Add a complete example analysis to docs
- [#629](https://github.com/SciLifeLab/Sarek/pull/629) - Add a complete example analysis to docs
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this one really was the #639

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we should keep the PR names in the description lines, even if they are long. Now I am confused since both #629 and #639 are docs-related PRs, I guess it is #639 here since that is "Added" not only updated, is it right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has not to be the PR name.
It could be a shorter description, since a PR can fall into Added, Changed, Removedor evenFixedcategory at the same time. For meAddedis anything new andChanged` is anything updated

Comment thread .travis.yml
Comment thread scripts/zenodo_upload.py
@maxulysse maxulysse merged commit 1539230 into SciLifeLab:dev Sep 21, 2018
jherrero referenced this pull request in UCL-BLIC/Sarek_v2.2.1 Apr 11, 2019
To process targeted sequencing with a target BED
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants