This repository was archived by the owner on Jan 27, 2020. It is now read-only.
Add Tuebingen specific configuration parameters#673
Merged
maxulysse merged 2 commits intoSciLifeLab:devfrom Oct 24, 2018
apeltzer:dev
Merged
Add Tuebingen specific configuration parameters#673maxulysse merged 2 commits intoSciLifeLab:devfrom apeltzer:dev
maxulysse merged 2 commits intoSciLifeLab:devfrom
apeltzer:dev
Conversation
Collaborator
Author
|
If you#re happy, I'll config descriptions as well in the docs and update the Changelog |
Member
|
That looks very good indeed. Usually I make the PR, and then commit the CHANGELOG with [skip ci] |
Collaborator
Author
|
Can do that as well, but can't commit directly to Sarek but just send in PRs from my fork |
Member
|
Only doing PR myself, I have the rights to make commit on the repo, but I don't |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
devbranchmasterbranch./scripts/test.sh -p docker -t ALL).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedThis adds configuration for Tuebingen infrastructure (BinAC cluster, CFC Cluster) and adds a more generic resource config for these resources. We can get this for others up as well, but it works quite nicely here on the servers. I also added the new
publishDirModeparams automatically :-)