Skip to content
This repository was archived by the owner on Jan 27, 2020. It is now read-only.

Enhance Qualimap BAMQC#693

Merged
maxulysse merged 6 commits intoSciLifeLab:devfrom
maxulysse:Qualimap
Nov 27, 2018
Merged

Enhance Qualimap BAMQC#693
maxulysse merged 6 commits intoSciLifeLab:devfrom
maxulysse:Qualimap

Conversation

@maxulysse
Copy link
Copy Markdown
Member

@maxulysse maxulysse commented Nov 26, 2018 •
edited
Loading

Following @parlundin request:

  • Use more cpus in parrallel
  • Add some extra flags
  • Add one extra BAMQC process to run on the mapped bams

PR checklist

  • PR is made against dev branch
  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • CHANGELOG.md is updated

alneberg
alneberg reviewed Nov 26, 2018
View reviewed changes
Comment thread main.nf Outdated
@maxulysse
Copy link
Copy Markdown
Member Author

maxulysse commented Nov 27, 2018

Quick question, since we enhanced BAMQC, should we do the same for samtools stats?

alneberg
alneberg approved these changes Nov 27, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@maxulysse maxulysse merged commit be59f74 into SciLifeLab:dev Nov 27, 2018
@maxulysse maxulysse deleted the Qualimap branch November 27, 2018 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@alneberg alneberg alneberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxulysse @alneberg
⚡