Skip to content
This repository was archived by the owner on Jan 27, 2020. It is now read-only.

AWS Batch queue parameter#696

Merged
maxulysse merged 6 commits intoSciLifeLab:devfrom
KochTobi:AWSQueueParam
Dec 3, 2018
Merged

AWS Batch queue parameter#696
maxulysse merged 6 commits intoSciLifeLab:devfrom
KochTobi:AWSQueueParam

Conversation

@KochTobi
Copy link
Copy Markdown
Collaborator

@KochTobi KochTobi commented Dec 2, 2018

AWS Batch queue param

Currently the AWS Batch queue ist hardcoded in the aws-batch.conf which is not ideal. This pull request introduces a command line parameter to set the awsqueue. When using the awsbatch profile this parameter has to be provided otherwise the scripts fail.

PR checklist

  • PR is made against dev branch
  • PR is a hotfix against master branch
  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/SciLifeLab/Sarek/blob/master/.github/CONTRIBUTING.md

Tobias and others added 6 commits November 20, 2018 10:19
Comment thread buildContainers.nf
Comment thread buildReferences.nf
@maxulysse
Copy link
Copy Markdown
Member

I like this very much.
Do you have any more modifications, or can I merge it?

@maxulysse maxulysse merged commit 347bebb into SciLifeLab:dev Dec 3, 2018
@KochTobi KochTobi deleted the AWSQueueParam branch December 18, 2018 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants