Skip to content
This repository was archived by the owner on Jan 27, 2020. It is now read-only.

Run bamQC on the recalibrated BAMs#720

Merged
szilvajuhos merged 2 commits intoSciLifeLab:devfrom
maxulysse:BamQC
Jan 31, 2019
Merged

Run bamQC on the recalibrated BAMs#720
szilvajuhos merged 2 commits intoSciLifeLab:devfrom
maxulysse:BamQC

Conversation

@maxulysse
Copy link
Copy Markdown
Member

@maxulysse maxulysse commented Jan 31, 2019

  • removed old channels and comments
  • The second BamQC (and samtools stats) are now run on the recalibrated BAMs (before it was on the MarkDuplicates)

PR checklist

  • PR is made against dev branch
  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • CHANGELOG.md is updated

szilvajuhos
szilvajuhos approved these changes Jan 31, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@szilvajuhos szilvajuhos merged commit 720e439 into SciLifeLab:dev Jan 31, 2019
@maxulysse maxulysse deleted the BamQC branch February 1, 2019 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alneberg alneberg Awaiting requested review from alneberg

1 more reviewer

@szilvajuhos szilvajuhos szilvajuhos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxulysse @szilvajuhos
⚡