(chore): Explicitly specify GitHub mode when using GitHub API#17746
Merged
(chore): Explicitly specify GitHub mode when using GitHub API#17746
Conversation
📝 WalkthroughWalkthroughThis pull request updates approximately 180+ Scoop package manifest files across the bucket directory. The changes uniformly replace the Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes The changes demonstrate high homogeneity—nearly identical field renaming applied consistently across 180+ files with no logic modifications. Once the pattern is verified in a sample of files, the remainder can be efficiently spot-checked. One file (bitwarden.json) contains an anomalous change with unexplained numeric entries that warrants closer inspection, adding minimal additional effort. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
bucket/bloop.json (1)
1-23:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winReminder: Scoop manifests should use CRLF line endings.
I can’t verify line endings from the excerpt here—please ensure
bucket/bloop.jsonis CRLF (per the repo’s manifest requirements) to avoid CI/lint issues.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/bloop.json` around lines 1 - 23, The manifest currently may have LF endings; convert the bucket/bloop.json manifest (identify by keys like "version": "0.6.5" and "pre_install") to use CRLF line endings, update the file so every line ends with CRLF, save and commit the change, and ensure the committed file retains CRLF (or add/verify a .gitattributes entry for JSON manifests if needed) so CI/lint will accept the manifest.bucket/ghidra.json (1)
1-53:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winEnsure Scoop CRLF line endings.
Scoop manifests in
bucket/are required to use CRLF line endings. Please confirmbucket/ghidra.jsonis CRLF (and not LF from the patch/tooling). If unsure, re-format with:.\bin\formatjson.ps1 -App ghidraand/or ensure the file is checked out/committed with CRLF.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/ghidra.json` around lines 1 - 53, The ghidra.json manifest currently has LF line endings; convert it to CRLF, reformat and recommit. Run the provided formatter (.\bin\formatjson.ps1 -App ghidra) to normalize CRLF, or set Git to checkout with CRLF (e.g., enable core.autocrlf or re-checkout the file) then re-save/commit the manifest so bucket/ghidra.json uses CRLF line endings before pushing.bucket/ffstudio.json (1)
22-27:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRemove hardcoded version from regex/autoupdate to keep updates working.
Line 22 and Line 27 are pinned to
0.2.7, so future releases can fail detection or generate stale URLs during autoupdate.Suggested fix
- "regex": "download/v(?<version>[\\d.]+)/FFStudio_0.2.7_x64_en-US-(?<commit>[a-f0-9]+)\\.msi" + "regex": "download/v(?<version>[\\d.]+)/FFStudio_[\\d.]+_x64_en-US-(?<commit>[a-f0-9]+)\\.msi" @@ - "url": "https://github.com/Draver93/ff-studio/releases/download/v$version/FFStudio_0.2.7_x64_en-US-$matchCommit.msi" + "url": "https://github.com/Draver93/ff-studio/releases/download/v$version/FFStudio_$version_x64_en-US-$matchCommit.msi"Please also align with the manifest docs:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines: “NEVER allow hardcoded version numbers in the
autoupdateblock … ensure paths are properly parameterized.”🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/ffstudio.json` around lines 22 - 27, The regex field currently hardcodes "0.2.7" and the autoupdate URL in autoupdate.architecture.64bit.url repeats that hardcoded version; remove the fixed "0.2.7" from the regex and make the pattern capture the version generically (keep the existing named capture group "version" and "commit"), then update autoupdate.architecture.64bit.url to use the captured $version and $matchCommit placeholders instead of the literal 0.2.7 so filenames/URLs are parameterized for future releases (adjust the "regex" and "autoupdate" entries to match each other).bucket/folo.json (1)
5-5:⚠️ Potential issue | 🟠 MajorCorrect license identifier and use non-deprecated SPDX form.
The
licensefield is set to"GPL-3.0", which has two issues:
- Incorrect identifier: The upstream project (RSSNext/Folo) is licensed under AGPL-3.0 (GNU Affero General Public License v3.0), not GPL-3.0.
- Deprecated form:
"GPL-3.0"is a deprecated bare SPDX identifier; the suffixed forms (-onlyor-or-later) must be used instead.Update to
"AGPL-3.0-only"(or"AGPL-3.0-or-later"if applicable based on upstream).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/folo.json` at line 5, The license value in folo.json currently uses the wrong and deprecated SPDX identifier ("GPL-3.0"); update the "license" field to the correct SPDX identifier for the upstream project by replacing the value with "AGPL-3.0-only" (or "AGPL-3.0-or-later" if the upstream allows later versions) so the manifest uses a valid, non-deprecated SPDX form.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b218277a-ae17-45f7-bc29-0cb4a6d09f69
📒 Files selected for processing (131)
bucket/86box.jsonbucket/adventuregamestudio.jsonbucket/aegisub-arch1t3cht.jsonbucket/age.jsonbucket/anki.jsonbucket/anytype.jsonbucket/archi.jsonbucket/bambu-studio.jsonbucket/biblioteq.jsonbucket/bitwarden.jsonbucket/bloop.jsonbucket/boilr.jsonbucket/browseros.jsonbucket/bulk-crap-uninstaller.jsonbucket/cake-wallet.jsonbucket/capframex.jsonbucket/cefflashbrowser.jsonbucket/chromium.jsonbucket/clementine.jsonbucket/clingo.jsonbucket/compactgui.jsonbucket/converseen.jsonbucket/debugtron.jsonbucket/deeplx.jsonbucket/dismplusplus.jsonbucket/dn-famitracker.jsonbucket/dosbox-x.jsonbucket/duckdns.jsonbucket/duplicati.jsonbucket/effekseer.jsonbucket/exhyperv.jsonbucket/fancontrol.jsonbucket/ffstudio.jsonbucket/fluidsynth.jsonbucket/folo.jsonbucket/fontforge.jsonbucket/free-shooter.jsonbucket/freecad.jsonbucket/freetube.jsonbucket/fvim.jsonbucket/garbro.jsonbucket/ghidra.jsonbucket/gitextensions.jsonbucket/github.jsonbucket/gnucash.jsonbucket/goldendict.jsonbucket/gossip.jsonbucket/hemmelig.jsonbucket/hoppscotch.jsonbucket/hydrus-network.jsonbucket/ilspy.jsonbucket/inkscape-extension-sozi.jsonbucket/insomnia.jsonbucket/insomnium.jsonbucket/ios-webkit-debug-proxy.jsonbucket/ipfilter-updater.jsonbucket/jasper.jsonbucket/jexiftoolgui.jsonbucket/kdoc-formatter.jsonbucket/librecad.jsonbucket/lightbulb.jsonbucket/linkerd.jsonbucket/liteide.jsonbucket/magicavoxel.jsonbucket/mediaelch.jsonbucket/meshroom.jsonbucket/moosync.jsonbucket/mpc-hc-fork.jsonbucket/mpv-git.jsonbucket/neovim-qt.jsonbucket/notesnook.jsonbucket/odict.jsonbucket/onlyoffice-desktopeditors.jsonbucket/persepolis.jsonbucket/playnite.jsonbucket/powertoys.jsonbucket/prusaslicer.jsonbucket/puttie.jsonbucket/qefi-entry-manager.jsonbucket/redasm.jsonbucket/regiontoshare.jsonbucket/retroshare.jsonbucket/ripme.jsonbucket/rssguard.jsonbucket/saber.jsonbucket/scoop-completion.jsonbucket/scoop-sd.jsonbucket/sdl2-image.jsonbucket/sdl2-mixer.jsonbucket/sdl2-ttf.jsonbucket/sdl2.jsonbucket/shaderglass.jsonbucket/simplewall.jsonbucket/skylark.jsonbucket/so.jsonbucket/soundswitch.jsonbucket/sozi.jsonbucket/spicetify-themes.jsonbucket/spotify-qt.jsonbucket/stack-wallet.jsonbucket/standardnotes.jsonbucket/status.jsonbucket/streamlabs-obs.jsonbucket/streamlink.jsonbucket/subsync.jsonbucket/supermium.jsonbucket/suwayomi-server.jsonbucket/switchhosts.jsonbucket/tcno-acc-switcher.jsonbucket/tern-subtitle-file-translator.jsonbucket/thonny.jsonbucket/thorium.jsonbucket/tlaplus-toolbox.jsonbucket/todolist.jsonbucket/total-registry.jsonbucket/ubports-installer.jsonbucket/uefitool.jsonbucket/uniextract2.jsonbucket/universal-android-debloater.jsonbucket/vcxsrv.jsonbucket/virgo.jsonbucket/wasabi-wallet.jsonbucket/windterm.jsonbucket/wox.jsonbucket/yacreader.jsonbucket/yesplaymusic.jsonbucket/yoke.jsonbucket/youtube-dl-gui.jsonbucket/zeronet.jsondeprecated/fmedia.jsondeprecated/nekoray.json
Contributor
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with 86box
adventuregamestudio
aegisub-arch1t3cht
age
anki
anytype
archi
bambu-studio
biblioteq
bitwarden
bloop
boilr
browseros
bulk-crap-uninstaller
cake-wallet
capframex
cefflashbrowser
chromium
clementine
clingo
compactgui
converseen
debugtron
deeplx
dismplusplus
dn-famitracker
dosbox-x
duckdns
duplicati
effekseer
exhyperv
fancontrol
ffstudio
fluidsynth
folo
fontforge
free-shooter
freecad
freetube
fvim
garbro
ghidra
gitextensions
github
gnucash
goldendict
gossip
hemmelig
hoppscotch
hydrus-network
ilspy
inkscape-extension-sozi
insomnia
insomnium
ios-webkit-debug-proxy
ipfilter-updater
jasper
jexiftoolgui
kdoc-formatter
librecad
lightbulb
linkerd
liteide
magicavoxel
mediaelch
meshroom
moosync
mpc-hc-fork
mpv-git
neovim-qt
notesnook
odict
onlyoffice-desktopeditors
persepolis
playnite
powertoys
prusaslicer
puttie
qefi-entry-manager
redasm
regiontoshare
retroshare
ripme
rssguard
saber
scoop-completion
scoop-sd
sdl2-image
sdl2-mixer
sdl2-ttf
sdl2
shaderglass
simplewall
skylark
so
soundswitch
sozi
spicetify-themes
spotify-qt
stack-wallet
standardnotes
status
streamlabs-obs
streamlink
subsync
supermium
suwayomi-server
switchhosts
tcno-acc-switcher
tern-subtitle-file-translator
thonny
thorium
tlaplus-toolbox
todolist
total-registry
ubports-installer
uefitool
uniextract2
universal-android-debloater
vcxsrv
virgo
wasabi-wallet
windterm
wox
yacreader
yesplaymusic
yoke
youtube-dl-gui
zeronet
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per ScoopInstaller/Scoop#6641, to make authenticated GitHub API requests with a token in checkver, GitHub mode must be explicitly specified. Additionally,
checkver.githubnow allows configuring either a GitHub repo URL or a GitHub API URL.Some
checkvermay still not work. However, since there is still another breaking change (ScoopInstaller/Scoop#6653) that hasn't been merged yet, we may wait until it is merged before fixing this issue to avoid duplicating work.<manifest-name[@version]|chore>: <general summary of the pull request>