feat: Support checkver's option "THROW_ERROR"#5
feat: Support checkver's option "THROW_ERROR"#5rashil2000 merged 1 commit intoScoopInstaller:mainfrom CrendKing:main
Conversation
|
Nice observation!! |
|
We'll have to revert this PR for now. The changes in Scoop core haven't been released yet, and as a result all the Excavator runs are failing with this error. /cc @issaclin32 @CrendKing we should wait for Scoop core release and then merge again. |
|
Sorry. I forgot to mention this. Alternatively, we could change auto-pr to use the splat form to pass param (i.e. Add "ThrowError" to the $param HashTable only if the value is $true). Do you want that? I could do it. |
|
Changes to auto-pr.ps1 would again happen in the |
|
Of course. If you think this kind of changes happen rarely, and we don't need to bother a future-proof approach, then let's wait. |
|
Instead, can you do something like this: GithubActions/src/Action/Scheduled.psm1 Line 24 in 24f1008 |
|
To auto-pr.ps1? |

For issue ScoopInstaller/Scoop#4863.
Other than simply passing along the new option to underlying script, I noticed that the environment variables from GitHub Action yaml's
envsection are always converted to strings. For example, I tested the following in excavator.yml:For all these,
[bool] $env.fooare always true and($env.foo).GetType()are always System.String. So the existing[bool] $env:SKIP_UPDATEDis always true. Not very impacting since most people use'1'anyways. But if we want to default the newTHROW_ERRORto false, I think it's better to fix this and make it consistent. There are ways to convert string to boolean in PowerShell in more complete way, but I think checking equalization to'1'is probably good enough. Let me know if this needs change.