fix(system): Fix argument passing to Split-PathLikeEnvVar() in deprecated strip_path() (#5937)

Capella87 · niheaven · niheaven · commit 9839c8c11690 · 2024-05-13T18:43:38.000+08:00
Co-authored-by: Hsiao-nan Cheung &lt;niheaven@gmail.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - **scoop-search:** Catch error of parsing invalid manifest ([#5930](https://github.com/ScoopInstaller/Scoop/issues/5930))
 - **autoupdate:** Copy `PSCustomObject`-type properties within `autoupdate` to prevent reference changes ([#5934](https://github.com/ScoopInstaller/Scoop/issues/5934))
+- **system:** Fix argument passing to `Split-PathLikeEnvVar()` in deprecated `strip_path()` ([#5937](https://github.com/ScoopInstaller/Scoop/issues/5937))
 
 ## [v0.4.1](https://github.com/ScoopInstaller/Scoop/compare/v0.4.0...v0.4.1) - 2024-04-25
 
diff --git a/lib/system.ps1 b/lib/system.ps1
@@ -162,7 +162,7 @@ function env($name, $global, $val) {
 
 function strip_path($orig_path, $dir) {
     Show-DeprecatedWarning $MyInvocation 'Split-PathLikeEnvVar'
-    Split-PathLikeEnvVar -Name $dir -Path $orig_path
+    Split-PathLikeEnvVar -Pattern @($dir) -Path $orig_path
 }
 
 function add_first_in_path($dir, $global) {

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ function env($name, $global, $val) {`
`162`	`162`
`163`	`163`	`function strip_path($orig_path, $dir) {`
`164`	`164`	`Show-DeprecatedWarning $MyInvocation 'Split-PathLikeEnvVar'`
`165`		`- Split-PathLikeEnvVar -Name $dir -Path $orig_path`
	`165`	`+ Split-PathLikeEnvVar -Pattern @($dir) -Path $orig_path`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`function add_first_in_path($dir, $global) {`