feature(decompress): Add 'ExtractDir' to 'Expand-...' functions#3466
Merged
r15ch13 merged 2 commits intoScoopInstaller:developfrom May 16, 2019
Merged
feature(decompress): Add 'ExtractDir' to 'Expand-...' functions#3466r15ch13 merged 2 commits intoScoopInstaller:developfrom
r15ch13 merged 2 commits intoScoopInstaller:developfrom
Conversation
Ash258
reviewed
May 16, 2019
Contributor
|
LGTM by fast static review. Will test in few hours. |
Member
Author
|
Tested 'TrimEnd', Also fix nested 7z extraction. All done. |
r15ch13
reviewed
May 16, 2019
This was referenced Jun 16, 2019
r15ch13
pushed a commit
that referenced
this pull request
Jun 24, 2019
* feature(decompress): Add 'ExtractDir' to 'Expand-...' functions * Fix 'TrimEnd' and nested 7z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
$extract_dirand$extract_totodecompress.ps1so as to not runrobocopyso many times.Tested on
extract_dir, 7z/nupkg)extract_dir, msiexec/lessmsi)extract_dirandextract_to)extract_to)extract_tooverwrite)