feat(compress): Allow 'Expand-InnoArchive -ExtractDir' to accept '{xxx}'#3487
Merged
r15ch13 merged 1 commit intoScoopInstaller:developfrom May 30, 2019
Merged
feat(compress): Allow 'Expand-InnoArchive -ExtractDir' to accept '{xxx}'#3487r15ch13 merged 1 commit intoScoopInstaller:developfrom
r15ch13 merged 1 commit intoScoopInstaller:developfrom
Conversation
Ash258
reviewed
May 30, 2019
Contributor
Ash258
left a comment
There was a problem hiding this comment.
LGTM.
I am not sure how reliable would be to depend on curly brackets. But fur current use cases this is enough.
Member
Author
|
I've tested for freedownloadmanager, and it works fine. See attached PR. |
r15ch13
pushed a commit
that referenced
this pull request
Jun 24, 2019
amorphobia
added a commit
to amorphobia/siku
that referenced
this pull request
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #3466 (comment)
Now
freedownloadmanager'sinstaller.scriptshould be simplified to (see ScoopInstaller/Extras#2220)