Skip to content

feat(compress): Allow 'Expand-InnoArchive -ExtractDir' to accept '{xxx}'#3487

Merged
r15ch13 merged 1 commit intoScoopInstaller:developfrom
niheaven:fix-compress
May 30, 2019
Merged

feat(compress): Allow 'Expand-InnoArchive -ExtractDir' to accept '{xxx}'#3487
r15ch13 merged 1 commit intoScoopInstaller:developfrom
niheaven:fix-compress

Conversation

@niheaven
Copy link
Copy Markdown
Member

@niheaven niheaven commented May 30, 2019

ref: #3466 (comment)

Now freedownloadmanager's installer.script should be simplified to (see ScoopInstaller/Extras#2220)

"installer": {
    "script": [
        "Expand-InnoArchive -Path \"$dir\\$fname\"",
        "Expand-InnoArchive -Path \"$dir\\$fname\" -ExtractDir '{code_CefInstallDir}' -Removal"
    ]
}

Copy link
Copy Markdown
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I am not sure how reliable would be to depend on curly brackets. But fur current use cases this is enough.

Comment thread lib/decompress.ps1
@niheaven
Copy link
Copy Markdown
Member Author

I've tested for freedownloadmanager, and it works fine. See attached PR.

@r15ch13 r15ch13 changed the title feat(compress): Allow 'Expand-InnoArchive''s 'ExtractDir' to accept '{xxx}' feat(compress): Allow 'Expand-InnoArchive -ExtractDir' to accept '{xxx}' May 30, 2019
@r15ch13 r15ch13 merged commit 81e3cf6 into ScoopInstaller:develop May 30, 2019
amorphobia added a commit to amorphobia/siku that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants