Skip to content

fix(scoop-bucket): Check for git before running command#4756

Merged
rashil2000 merged 3 commits intodevelopfrom
fix-bucket-git
Feb 24, 2022
Merged

fix(scoop-bucket): Check for git before running command#4756
rashil2000 merged 3 commits intodevelopfrom
fix-bucket-git

Conversation

@rashil2000
Copy link
Copy Markdown
Member

Hotfix for #4704

Comment thread libexec/scoop-bucket.ps1 Outdated
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
@niheaven
Copy link
Copy Markdown
Member

The code LGTM, please update CHANGLOG

@rashil2000 rashil2000 merged commit 40b2d95 into develop Feb 24, 2022
@rashil2000 rashil2000 deleted the fix-bucket-git branch February 24, 2022 09:41
@HUMORCE
Copy link
Copy Markdown
Member

HUMORCE commented Feb 24, 2022

> scoop bucket list
Get-Date: C:\Users\HUMOR\scoop\apps\scoop\current\libexec\scoop-bucket.ps1:42
Line |
  42 |  …  --date=format:"`"%d-%m-%Y %H:%M:%S`"" --format='%ad' -n 1 | Get-Date
     |                                                                 ~~~~~~~~
     | The input object cannot be bound to any parameters for the command either because the command does not
     | take pipeline input or the input and its properties do not match any of the parameters that take
     | pipeline input.
...

@rashil2000
Copy link
Copy Markdown
Member Author

image

image

How to reproduce?

@HUMORCE
Copy link
Copy Markdown
Member

HUMORCE commented Feb 24, 2022

screenshot_20220224164358

@HUMORCE
Copy link
Copy Markdown
Member

HUMORCE commented Feb 24, 2022

%ad
author date (format respects --date= option)

%aD
author date, RFC2822 style

if date formatting is not required, use %aD:

> git log --format='%aD' -n 1 | Get-Date

Thursday, February 24, 2022 12:03:00 PM

@rashil2000
Copy link
Copy Markdown
Member Author

image

image

PowerShell 5.1

@rashil2000
Copy link
Copy Markdown
Member Author

if date formatting is not required, use %aD:

Hmm, okay. Seems fine by me. Can you fix it?

@HUMORCE
Copy link
Copy Markdown
Member

HUMORCE commented Feb 24, 2022

screenshot_20220224170745

related to OS's datetime format. (unconfirmed)

se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
…er#4756)

* fix(scoop-bucket): Check for git before running command

* Apply suggestions from code review

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants