Skip to content

fix(scoop-bucket): Check for git before running command #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rashil2000 merged 3 commits into from
Feb 24, 2022
Merged

fix(scoop-bucket): Check for git before running command #4756

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d121106
fix(scoop-bucket): Check for git before running command
rashil2000 Feb 24, 2022
41b80b9
Apply suggestions from code review
rashil2000 Feb 24, 2022
dc9a1c7
Update CHANGELOG.md
rashil2000 Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libexec/scoop-bucket.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ function list_buckets {
Measure-Object | Select-Object -ExpandProperty Count
)
$updated = 'N/A'
if (Test-Path (Join-Path $source '.git')) {
$updated = git -C "`"$source`"" log --date=format:"`"%Y-%m-%d %H:%M:%S`"" --format='%ad' -n 1
if ((Test-Path (Join-Path $source '.git')) -and (Get-Command git -ErrorAction Ignore)) {
Comment thread
rashil2000 marked this conversation as resolved.
Outdated
$updated = git -C "`"$source`"" log --date=format:"`"%d-%m-%Y %H:%M:%S`"" --format='%ad' -n 1 | Get-Date
$source = git -C "`"$source`"" config remote.origin.url
} else {
$updated = (Get-Item "$source\bucket").LastWriteTime | Get-Date -Format 'yyyy-MM-dd HH:mm:ss'
$updated = (Get-Item "$source\bucket").LastWriteTime
$source = friendly_path $source
}
$buckets += New-Object PSObject -Property @{
Expand Down
⚡