refactor(reset_aliases): Move core function of reset_aliases to scoop#4794
Merged
refactor(reset_aliases): Move core function of reset_aliases to scoop#4794
reset_aliases to scoop#4794Conversation
niheaven
force-pushed
the
feature/refactor-reset_aliases
branch
from
df66e52 to
9f8a591
Compare
niheaven
requested review from
chawyehsu and
rashil2000
and removed request for
chawyehsu
rashil2000
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
reset_aliasesis added since scoop uses lots of PS alias (md, cd, gci, etc.) during its early development, and this function reset all alias to PS's default.Now Verb-Noun form of function names is used, so this is not needed.
The one added in
scoop.ps1is force use script (scoop) function instead of user-definded alias or function in global environment outsides scoop.Additionally,
ensure()is refactored andmkdirin test files are replaced byensure()How Has This Been Tested?
Passed tests.
Checklist: