Conversation
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
* scoop-download failure check, aria2 warn if uninstalled * Revert core.ps1 * Update CHANGELOG.md
* Update README.md * Update CHANGELOG.md
* added ability to use private github repositories To do this, define a gh_api_token in the sccop config, if the repository is private it will use the apis to get and use the asset id * corrected inherited linting error * updated url to pull filename * inlined get_headers and get-members functions and updated changelog * simplified host headers and switched to checkver_token from: astelmachonak-nydig * added ability to use private github repositories To do this, define a gh_api_token in the sccop config, if the repository is private it will use the apis to get and use the asset id * updated url to pull filename * inlined get_headers and get-members functions and updated changelog * simplified host headers and switched to checkver_token from: astelmachonak-nydig * Update lib/core.ps1 Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> * Update lib/core.ps1 Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> * Fix RegEx * Some tweaks * optimize Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Co-authored-by: Rashil Gandhi <rashil2000@gmail.com>
…KEN to SCOOP_GH_TOKEN (#4832) * Properly filtering null input in dl function when private_hosts is not set in config * Rename checkver_token to gh_token and SCOOP_CHECKVER_TOKEN to SCOOP_GH_TOKEN
* Update scoop-shim.ps1 * Update CHANGELOG.md
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Co-authored-by: Rashil Gandhi <rashil2000@gmail.com>
|
I created PR to GithubActions repo, needed for the new version due to the breaking change with config parameter rename: ScoopInstaller/GithubActions#7 |
tech189
reviewed
May 3, 2022
Member
Member
Author
Member
Sure. #4870 is mergable once the strikeout text is cleaned up. I tried fixing #4870 but GitHub's UI wouldn't let me, which spurred me to create #4892, not to negate @Tyler887's work, but simply to express a preference. Here's the poll: |
Member
Member
Author
Member
|
#4903 works for me, thx! |
Co-authored-by: Chawye Hsu <chawyehsu@hotmail.com> Co-authored-by: Tyler887 <tylermageeshields@gmail.com>
rashil2000
approved these changes
May 8, 2022
issaclin32
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
BREAKING CHANGES
checkver_tokentogh_tokenandSCOOP_CHECKVER_TOKENtoSCOOP_GH_TOKEN(Rename checkver_token to gh_token and SCOOP_CHECKVER_TOKEN to SCOOP_GH_TOKEN #4832, feat(config): Try SCOOP_GH_TOKEN value first before gh_token value from config #4842)Features
-a/--allswitch to cleanup all apps #4906)Bug Fixes
Get-LocalBucket(fix(bucket): Return empty list correctly inGet-LocalBucket#4885)$global, check both local and global installed (fix(installed): If no$global, check both local and global installed #4798)(chore)(fix(update): Skip logs starting with(chore)#4800)Performance Improvements
Code Refactoring
$PSScriptRootinstead ofrelpath(refactor(relpath): Use$PSScriptRootinstead ofrelpath#4793)reset_aliasestoscoop(refactor(reset_aliases): Move core function ofreset_aliasestoscoop#4794)Builds
Documentation
Close Issues
scoop downloadsucceeds even when no free space #4810scoop prefixnot working for global installs #4790Credits
Thanks to the following contributors (ordered by PR merging time):
@niheaven @rashil2000 @chawyehsu @e6c31d @tech189 @tmsmith @astelmachonak-nydig @kingster @kiennq @CrendKing @cskrisz @lewis-yeung