fix(bucket): Return empty list correctly in Get-LocalBucket#4885
Merged
niheaven merged 1 commit intoScoopInstaller:developfrom Apr 27, 2022
Merged
fix(bucket): Return empty list correctly in Get-LocalBucket#4885niheaven merged 1 commit intoScoopInstaller:developfrom
Get-LocalBucket#4885niheaven merged 1 commit intoScoopInstaller:developfrom
Conversation
rashil2000
reviewed
Apr 24, 2022
rashil2000
reviewed
Apr 24, 2022
rashil2000
reviewed
Apr 24, 2022
Contributor
Author
|
@rashil2000 Changed and re-pushed. Please take a look. Thanks for your patience. |
rashil2000
previously approved these changes
Apr 25, 2022
niheaven
requested changes
Apr 25, 2022
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Co-authored-by: Rashil Gandhi <rashil2000@gmail.com>
niheaven
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Return a zero-length list instead of
$nullinGet-LocalBucket.Adjust the output message for
scoop alias listwhen there is no alias found.Adjust the output message for
scoop cache showwhen there is no cache found.Motivation and Context
I ran into an error when I removed all buckets and was trying to add them back using URLs of mirrors, which means running
scoop bucket listwhen there is nothing in$SCOOP\buckets:The
Get-LocalBucketreturns$nullin this case, soFind-BucketDirectorygets the default valuemainfor$Name:Scoop/lib/buckets.ps1
Lines 126 to 128 in e6d0371
Scoop/lib/buckets.ps1
Lines 13 to 14 in e6d0371
To fix this, we should use a zero-length list instead and give a tip of adding the default
mainbucket.No additional description.
scoop cache showshows the following message when there is no cache found:I think it's better to change it to something like this:
How Has This Been Tested?
Just run as usual:
Checklist: