Rename checkver_token to gh_token and SCOOP_CHECKVER_TOKEN to SCOOP_GH_TOKEN

[ghost]

• Rename checkver_token to gh_token and SCOOP_CHECKVER_TOKEN to SCOOP_GH_TOKEN
• Follow up fix for feat(install): Allow downloading from private repositories #4254 (filtering null input in dl function when private_hosts is not set in config)

Checklist:

• I have read the Contributing Guide.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.

[rashil2000]

Additionally, can you replace all instances of checkver_token with gh_token (4 in total) in this PR?

And add an entry in the changelog

[ghost]

@rashil2000 done, please review

[rashil2000]

https://github.com/ScoopInstaller/GithubActions/blob/bd73d5711c4ad072c73e17d41b592e57d71892c6/src/Action/Scheduled.psm1#L24

This also needs to be updated then, I'll do it once this is merged

[rashil2000]

https://github.com/ScoopInstaller/GithubActions/blob/bd73d5711c4ad072c73e17d41b592e57d71892c6/src/Action/Scheduled.psm1#L24

This also needs to be updated then, I'll do it once this is merged

This can't be done yet. We will have to wait for a new release.

[niheaven]

This tends to be a refactor, not a feature, will change the CHANGELOG next time.

[ghost]

This tends to be a refactor, not a feature, will change the CHANGELOG next time.

I was debating between these two and decided to go with feature since this change affects the users (env var change, configuration parameter change). However if refactoring in the sense you use it allows "breaking" changes, I agree this is refactoring.

[niheaven]

Yes, adding a "breaking change" at the top of release notes for this one is a good idea, since it is UX change, right? 😄

[ghost]

Yes, adding a "breaking change" at the top of release notes for this one is a good idea, since it is UX change, right? 😄

Exactly. I searched in the changelog for something like this, but didn't find...

[niheaven]

Exactly. I searched in the changelog for something like this, but didn't find...

Because we haven't had such BREAKING CHANGES since we have changelog...