fix: Correctly quote $@ in sh->ps1 shims#4809
Merged
rashil2000 merged 1 commit intoScoopInstaller:developfrom Mar 14, 2022
e6c31d:patch-1
Merged
fix: Correctly quote $@ in sh->ps1 shims#4809rashil2000 merged 1 commit intoScoopInstaller:developfrom e6c31d:patch-1
rashil2000 merged 1 commit intoScoopInstaller:developfrom
e6c31d:patch-1
Conversation
Member
|
Hey @e6c31d, thanks for tracking down the bug! For a contribution, you need to open the PR against the |
Contributor
Author
|
@rashil2000 Done. |
rashil2000
approved these changes
Mar 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correctly quote $@ in sh->ps1 shims
Motivation and Context
Closes #4808
How Has This Been Tested?
~/scoop/apps/scoop/currentscoop update~/scoop/shims/scoopis updated correctlyscoop update '*'from git bash, which succeeded.Checklist: