refactor(bucket): Move 'Find-Manifest' and 'list_buckets' to 'buckets'

[niheaven]

Description

find_manifest() and Find-Manifest() (former locate()) have similar functionality and now be merged into Find-Manifest().

Also move list_buckets() from libexec\scoop-bucket.ps1 to lib\buckets.ps1.

Motivation and Context

Discussed with @rashil2000

How Has This Been Tested?

scoop bucket and `scoop

Checklist:

• I have read the Contributing Guide.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.

[rashil2000]

Nice change!

Since we're refactoring bucket methods, can we also incorporate #3348? This will allow us to close #2123

[niheaven]

Okay, wait a moment.

[niheaven]

Done. Now check for duplicated buckets.

[rashil2000]

The bucket-add function should stop at the first error (ERROR github.com/ScoopInstaller/Extras is not a valid Git URL!), no?

[niheaven]

So you mean we should assume default protocol? The error you met is no protocol provided (it is http? https? ftp? ftps? ssh?)

Ref is here: https://git-scm.com/docs/git-clone#_git_urls

[rashil2000]

I meant that we're showing the error twice. When we get an error (any error) from the Convert-RepositoryUri function, we should stop the add_bucket function (instead of proceeding to the Checking repo... step)

[niheaven]

Oh, sorry, haven't noticed that, will change it later.

[rashil2000]

Since the location of Find-Manifest has changed, has the import of this function in all other source files been taken care of?

[niheaven]

Since the location of Find-Manifest has changed, has the import of this function in all other source files been taken care of?

buckets.ps1 is imported in every lib-exec scripts, so it's not a problem.

[lorengordon]

Traced this patch as the cause of this issue #4917