Skip to content

feat(checkver,auto-pr): Allow passing file path#5019

Merged
rashil2000 merged 4 commits intodevelopfrom
checkver-file
Jul 1, 2022
Merged

feat(checkver,auto-pr): Allow passing file path#5019
rashil2000 merged 4 commits intodevelopfrom
checkver-file

Conversation

@rashil2000
Copy link
Copy Markdown
Member

@rashil2000 rashil2000 commented Jun 24, 2022

Description

Allow passing local file paths to checkver utility.

Motivation and Context

Closes #4606

Relates to #3481

How Has This Been Tested?

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven
Copy link
Copy Markdown
Member

Please use ParameterSet to choose between Dir and File, or rename them to Path and check if it is directory or file later. The latter approach is better, IMO.

@rashil2000
Copy link
Copy Markdown
Member Author

rashil2000 commented Jun 27, 2022

I have reused the $App parameter (like the linked PR)

Copy link
Copy Markdown
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one remark, this should go to Builds in CHANGELOG

@rashil2000 rashil2000 merged commit 53f0e9a into develop Jul 1, 2022
@rashil2000 rashil2000 deleted the checkver-file branch July 1, 2022 06:42
slaughtering pushed a commit to slaughtering/scoop that referenced this pull request Jul 7, 2022
* feat(checkver,auto-pr): Allow passing file path

* changelog

* reuse $App parameter

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants