Allow passing JSON file to checkver

[r15ch13]

• Moved JSON parsing into the queue
  • Removes some loops
• Allow passing a JSON file path to checkver.ps1
  • Example: > .\bin\checkver.ps1 -App ..\somewhere\bucket\test.json -Force
• Use proper parameters values for next()
• Improve event cleanup

[r15ch13]

ping @Ash258 @niheaven

[Ash258]

Looks good by fast static review.

I do not know when i will find time to do proper review. I guess Friday / weekend evenings should be good.

[niheaven]

Full diff:

diff --git a/bin/checkver.ps1 b/bin/checkver.ps1
index 5d21aff8c..b76f38b70 100644
--- a/bin/checkver.ps1
+++ b/bin/checkver.ps1
@@ -48,7 +48,6 @@
 #>
 param(
     [String] $App = '*',
-    [Parameter(Mandatory = $true)]
     [ValidateScript( {
         if (!(Test-Path $_ -Type Container)) {
             throw "$_ is not a directory!"
@@ -56,7 +55,7 @@ param(
             $true
         }
     })]
-    [String] $Dir,
+    [String] $Dir = '.',
     [Switch] $Update,
     [Switch] $ForceUpdate,
     [Switch] $SkipUpdated,
@@ -75,10 +74,9 @@ param(
 # get apps to check
 $Queue = @()
 if((Test-Path $App) -and $App -ne "*") {
-    $Queue = @(Get-ChildItem $App)
+    $Queue = @(Get-Item -Path (Convert-Path -Path $App))
 } else {
-    $Dir = Resolve-Path $Dir
-    $Queue = @(Get-ChildItem -Path $Dir -Filter "$App.json")
+    $Queue = @(Get-ChildItem -Path (Convert-Path -Path $Dir) -Filter "$App.json")
 }
 
 # clear any existing events
@@ -211,7 +209,7 @@ while ($in_progress -gt 0) {
     }
 
     if (!$regex -and $replace) {
-        next "'replace' requires 're' or 'regex'"
+        next $app "'replace' requires 're' or 'regex'"
         continue
     }
 

[niheaven]

Suggested change

	$Queue = @(Get-ChildItem $App)
	$Queue = @(Get-Item -Path (Convert-Path -Path $App))

[niheaven]

Suggested change

	$Queue = @(Get-ChildItem -Path $Dir -Filter "$App.json")
	$Queue = @(Get-ChildItem -Path (Convert-Path -Path $Dir) -Filter "$App.json")

Also remove above $Dir = Resolve-Path $Dir

[rashil2000]

Superceded by #5019