fix(shim): Avoid unexpected output of list subcommand#5681
Merged
rashil2000 merged 2 commits intoScoopInstaller:developfrom Oct 10, 2023
Merged
fix(shim): Avoid unexpected output of list subcommand#5681rashil2000 merged 2 commits intoScoopInstaller:developfrom
list subcommand#5681rashil2000 merged 2 commits intoScoopInstaller:developfrom
Conversation
lewis-yeung
force-pushed
the
fix-shim-list
branch
from
c9754a3 to
9db2df5
Compare
niheaven
reviewed
Oct 9, 2023
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
niheaven
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related: #5568. See my comment.
The usage of
scoop shim listshould be more explicit:scoop shim list [<shim_name>/<regex_pattern>...], since regular expression matching is used in this case.Motivation and Context
Closes #5568.
How Has This Been Tested?
Run:
scoop shim list scoo*Output:
Checklist:
developbranch.