Skip to content

Remove env_ensure_home #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r15ch13 merged 1 commit into from
May 4, 2018
Merged

Remove env_ensure_home #1967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions lib/install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ function install_app($app, $architecture, $global, $suggested, $use_cache = $tru
# persist data
persist_data $manifest $original_dir $persist_dir

# env_ensure_home $manifest $global (see comment for env_ensure_home)
post_install $manifest $architecture

# save info for uninstall
Expand Down Expand Up @@ -857,29 +856,6 @@ function env_rm($manifest, $global) {
}
}

# UNNECESSARY? Re-evaluate after 3-Jun-2017
# Supposedly some MSYS programs require %HOME% to be set, but I can't
# find any examples.
# Shims used to set %HOME% for the session, but this was removed.
# This function remains in case we need to support this functionality again
# (e.g. env_ensure_home in manifests). But if no problems arise by 3-Jun-2017,
# it's probably safe to delete this, and the call to it install_app
function env_ensure_home($manifest, $global) {
if($manifest.env_ensure_home -eq $true) {
if($global){
if(!(env 'HOME' $true)) {
env 'HOME' $true $env:ALLUSERSPROFILE
$env:HOME = $env:ALLUSERSPROFILE # current session
}
} else {
if(!(env 'HOME' $false)) {
env 'HOME' $false $env:USERPROFILE
$env:HOME = $env:USERPROFILE # current session
}
}
}
}

function pre_install($manifest, $arch) {
$pre_install = arch_specific 'pre_install' $manifest $arch
if($pre_install) {
Expand Down
⚡