Skip to content

Warn on shim overwrite #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r15ch13 merged 2 commits into from
May 4, 2018
Merged

Warn on shim overwrite #2033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7529bc3
Warn on shim overwrite
rasa Feb 20, 2018
79c2c16
Remove dead code
rasa Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions lib/core.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,38 @@ function movedir($from, $to) {
}
}

function get_app_name($path) {
if ($path -match '([^/\\]+)[/\\]current[/\\]') {
return $Matches[1].tolower()
}
return ""
}

function warn_on_overwrite($shim_ps1, $path) {
if (!([System.IO.File]::Exists($shim_ps1))) {
return
}
$reader = [System.IO.File]::OpenText($shim_ps1)
$line = $reader.ReadLine().replace("`r","").replace("`n","")
$reader.Close()
$shim_app = get_app_name $line
$path_app = get_app_name $path
if ($shim_app -eq $path_app) {
return
}
$filename = [System.IO.Path]::GetFileName($path)
warn "Overwriting shim to $filename installed from $shim_app"
}

function shim($path, $global, $name, $arg) {
if(!(test-path $path)) { abort "Can't shim '$(fname $path)': couldn't find '$path'." }
$abs_shimdir = ensure (shimdir $global)
if(!$name) { $name = strip_ext (fname $path) }

$shim = "$abs_shimdir\$($name.tolower())"

warn_on_overwrite "$shim.ps1" $path

# convert to relative path
pushd $abs_shimdir
$relative_path = resolve-path -relative $path
Expand Down
⚡