Skip to content

Better error handling during uninstallation.#2079

Merged
r15ch13 merged 1 commit intoScoopInstaller:masterfrom
excitoon-favorites:better-error-handling-during-uninstallation
May 4, 2018
Merged

Better error handling during uninstallation.#2079
r15ch13 merged 1 commit intoScoopInstaller:masterfrom
excitoon-favorites:better-error-handling-during-uninstallation

Conversation

@excitoon
Copy link
Copy Markdown
Contributor

@excitoon excitoon commented Mar 2, 2018

If one uninstalls more than one application and have an error, she will receive pretty random behaviour - scoop will either stops (skipping other applications) or continue to uninstall the current. This is so because continue doesn't works with pipes and some continue were supposed to exit current iteration of nested loop. When one calls continue from For-Each, PowerShell simply exits For-Each (the same effect as if it was break:

PS C:\Users\Chebotarev_V\scoop\apps\scoop\current> @(1,2,3,4) | % { echo $_; continue }
1
PS C:\Users\Chebotarev_V\scoop\apps\scoop\current> foreach($_ in @(1,2,3,4)) { echo $_; continue; }
1
2
3
4

@excitoon excitoon force-pushed the better-error-handling-during-uninstallation branch from 8338358 to 87ba237 Compare March 11, 2018 08:30
@excitoon
Copy link
Copy Markdown
Contributor Author

excitoon commented Mar 11, 2018

@rrelmy Done.

@rasa rasa added review-needed Asks for review of these changes and removed solve-conflicts labels Mar 12, 2018
Copy link
Copy Markdown
Member

@rasa rasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but untested)

@r15ch13 r15ch13 merged commit 8e1de57 into ScoopInstaller:master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-needed Asks for review of these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants