Skip to content

Add Expand-DarkArchive and some other dependency features#3450

Merged
r15ch13 merged 5 commits intodevelopfrom
feature/dark-deps
May 12, 2019
Merged

Add Expand-DarkArchive and some other dependency features#3450
r15ch13 merged 5 commits intodevelopfrom
feature/dark-deps

Conversation

@r15ch13
Copy link
Copy Markdown
Member

@r15ch13 r15ch13 commented May 11, 2019

  • Add Expand-DarkArchive helper function
  • Allow dark.exe from wixtoolset and 7zip-zstd as valid helpers
  • Add warnings to 'scoop checkup' for missing unpackers
  • Auto detect dependencies from pre_install/post_install and installer.script by simply searching for the function names.

Should be merge into develop before merging develop into master.
This will allow us to remove the dark dependency from some manifests.
Expand-7zipArchive is widely used without the manifest actually depending on it.
The installation will fail with the following message when Get-HelperPath returns nothing.

The expression after '&' in a pipeline element produced an object that was not valid. It must result in a command name, a script block, or a CommandInfo object.

#3417

Comment thread libexec/scoop-checkup.ps1 Outdated
Comment thread libexec/scoop-checkup.ps1 Outdated
@niheaven
Copy link
Copy Markdown
Member

dark needn't a seperated Expand- function since it is only used when we want to unpack WIX type installer. After using dark, we need extract_msi...

@r15ch13
Copy link
Copy Markdown
Member Author

r15ch13 commented May 12, 2019

@niheaven using this function will make manifest scripts cleaner and it's easier to use.

@r15ch13 r15ch13 merged commit 17253e4 into develop May 12, 2019
@r15ch13 r15ch13 deleted the feature/dark-deps branch May 12, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants