Add Expand-DarkArchive and some other dependency features#3450
Merged
Add Expand-DarkArchive and some other dependency features#3450
Conversation
Ash258
suggested changes
May 11, 2019
Member
|
|
Member
Author
|
@niheaven using this function will make manifest scripts cleaner and it's easier to use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand-DarkArchivehelper functiondark.exefrom wixtoolset and7zip-zstdas valid helperspre_install/post_installandinstaller.scriptby simply searching for the function names.Should be merge into
developbefore mergingdevelopintomaster.This will allow us to remove the
darkdependency from some manifests.Expand-7zipArchiveis widely used without the manifest actually depending on it.The installation will fail with the following message when
Get-HelperPathreturns nothing.#3417