Skip to content

feat(manifest): xpath support in checkver and autoupdate#3458

Merged
r15ch13 merged 5 commits intoScoopInstaller:developfrom
chawyehsu:patch-17
May 13, 2019
Merged

feat(manifest): xpath support in checkver and autoupdate#3458
r15ch13 merged 5 commits intoScoopInstaller:developfrom
chawyehsu:patch-17

Conversation

@chawyehsu
Copy link
Copy Markdown
Member

@chawyehsu chawyehsu commented May 13, 2019

Close #3451

TODO list:

  • xpath in checkver
  • xpath in autoupdate hash extraction
  • xpath in json schema

to be supplemented

@chawyehsu chawyehsu changed the title feat(manifest): support xpath in checkver and autoupdate feat(manifest): xpath support in checkver and autoupdate May 13, 2019
@chawyehsu chawyehsu marked this pull request as ready for review May 13, 2019 08:46
Copy link
Copy Markdown
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread bin/checkver.ps1
@r15ch13 r15ch13 merged commit f606285 into ScoopInstaller:develop May 13, 2019
@chawyehsu chawyehsu deleted the patch-17 branch May 14, 2019 02:50
@Ash258
Copy link
Copy Markdown
Contributor

Ash258 commented May 15, 2019

@h404bi Found one problematic xml file

According to multiple xpath testers and evaluators this is valid expression:
XML = https://sparkle.musescore.org/stable/3/win/appcast.xml
XPATH = /rss/channel/item/enclosure/@sparkle:version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants