feature(update): allow updating apps from local manifest or URL#3685
Merged
r15ch13 merged 7 commits intoScoopInstaller:developfrom Oct 14, 2019
scayssials:develop
Merged
feature(update): allow updating apps from local manifest or URL#3685r15ch13 merged 7 commits intoScoopInstaller:developfrom scayssials:develop
r15ch13 merged 7 commits intoScoopInstaller:developfrom
scayssials:develop
Conversation
Contributor
|
This is not enough. You need to cover dependcy resolver too. Update will fail on function |
Contributor
Author
|
moreover its not an elseif but an else, we always set the bucket name to "main" if it doesn't exist |
Ash258
suggested changes
Oct 13, 2019
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
Ash258
reviewed
Oct 13, 2019
Contributor
|
Add snippet bellow as PR description - Closes #3683
- Closes #3607 |
r15ch13
approved these changes
Oct 14, 2019
r15ch13
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.