Skip to content

Show manifest on installation #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rashil2000 merged 3 commits into from
Dec 8, 2021
Merged

Show manifest on installation #4155

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b618553
show manifest on installation
Nov 19, 2021
6964e0b
Inline function
MrNuggelz Nov 24, 2021
a97cd85
Update install.ps1
rashil2000 Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ function nightly_version($date, $quiet = $false) {
"nightly-$date_str"
}

function Test-ManifestReviewEnabled {
return get_config 'manifest-review' $false
}

Comment thread
rashil2000 marked this conversation as resolved.
Outdated
function install_app($app, $architecture, $global, $suggested, $use_cache = $true, $check_hash = $true) {
$app, $bucket, $null = parse_app $app
$app, $manifest, $bucket, $url = Find-Manifest $app $bucket
Expand All @@ -34,7 +38,18 @@ function install_app($app, $architecture, $global, $suggested, $use_cache = $tru
return
}

write-output "Installing '$app' ($version) [$architecture]"
if (Test-ManifestReviewEnabled) {
Comment thread
rashil2000 marked this conversation as resolved.
Outdated
$show_manifest = read-host -Prompt "Show manifest? [y/N]"
if ($show_manifest -eq "y") {
write-output "manifest:"
write-output $manifest | ConvertToPrettyJson
$answer = read-host -Prompt "Continue installation? [Y/n]"

if ($answer -eq "n") {
return
}
}
}
Comment thread
rashil2000 marked this conversation as resolved.

$dir = ensure (versiondir $app $version $global)
$original_dir = $dir # keep reference to real (not linked) directory
Expand Down
⚡