Skip to content

feat(schema): Enable autoupdate for 'license'#4528

Merged
niheaven merged 1 commit intodevelopfrom
fix-schema
Dec 1, 2021
Merged

feat(schema): Enable autoupdate for 'license'#4528
niheaven merged 1 commit intodevelopfrom
fix-schema

Conversation

@niheaven
Copy link
Copy Markdown
Member

Signed-off-by: Hsiao-nan Cheung <niheaven@gmail.com>
@niheaven
Copy link
Copy Markdown
Member Author

niheaven commented Nov 22, 2021

If there is any property that really needs to be updated, please add a comment.

@rashil2000
Copy link
Copy Markdown
Member

url is also a mandatory property, right?

@niheaven
Copy link
Copy Markdown
Member Author

It isn't if we want some meta manifest later.

@rashil2000
Copy link
Copy Markdown
Member

But for now we have no such feature for meta manifest. For now we should make url required. We can change it back later.

@niheaven
Copy link
Copy Markdown
Member Author

niheaven commented Nov 23, 2021

arch structure has arch url and no noarch url, so this could not be required...

@pratikpc
Copy link
Copy Markdown
Contributor

Also make description, homepage and license properties required.

This won't cause problems with repos which are using Scoop to maintain and update their own buckets right?

@niheaven
Copy link
Copy Markdown
Member Author

Yes, this is just a schema, and modification doesn't change user experience.

@niheaven niheaven merged commit ab8be95 into develop Dec 1, 2021
@niheaven niheaven deleted the fix-schema branch December 1, 2021 14:41
niheaven added a commit that referenced this pull request Dec 25, 2021
Related PRs:
- #4531 @filmor 
  - ac71fcc @niheaven 
- #4535 @rashil2000 
- #4522 @pratikpc 
- #4550 @niheaven 
- #4528 @niheaven 
- #4532 @MrNuggelz
- #4155 @MrNuggelz Co-authored-by: @rashil2000 
  - #4581 @niheaven 
  - fb496c4 @rashil2000 
- #4543 @rashil2000 Co-authored-by: @niheaven 
  - #4555 @rashil2000 
  - 3c90d1a @rashil2000 
  - 2ec00d5 @rashil2000 
- #4567 @rashil2000 
  - cbe29ed @rashil2000 
- #4570 @niheaven 
  - #4582 @niheaven 
- #4571 @niheaven 
- #3244 @nickbudi 
- #3821 @jfastnacht Co-authored-by: @rasa 
- #4578 @tukanos
- #4579 @rashil2000 

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com>
Co-authored-by: Ross Smith II <ross@smithii.com>
Co-authored-by: Benedikt Reinartz <filmor@gmail.com>
Co-authored-by: Joris <MrNuggelz@users.noreply.github.com>
Co-authored-by: Pratik Chowdhury <pratikc@live.co.uk>
Co-authored-by: Rashil Gandhi <rashil2000@gmail.com>
Co-authored-by: nickbudi <nickbudi@users.noreply.github.com>
Co-authored-by: Julian <github@fastnacht.consulting>
Co-authored-by: tukanos <patrik.svestka@gmail.com>
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
Related PRs:
- ScoopInstaller#4531 @filmor
  - ac71fcc @niheaven
- ScoopInstaller#4535 @rashil2000
- ScoopInstaller#4522 @pratikpc
- ScoopInstaller#4550 @niheaven
- ScoopInstaller#4528 @niheaven
- ScoopInstaller#4532 @MrNuggelz
- ScoopInstaller#4155 @MrNuggelz Co-authored-by: @rashil2000
  - ScoopInstaller#4581 @niheaven
  - fb496c4 @rashil2000
- ScoopInstaller#4543 @rashil2000 Co-authored-by: @niheaven
  - ScoopInstaller#4555 @rashil2000
  - 3c90d1a @rashil2000
  - 2ec00d5 @rashil2000
- ScoopInstaller#4567 @rashil2000
  - cbe29ed @rashil2000
- ScoopInstaller#4570 @niheaven
  - ScoopInstaller#4582 @niheaven
- ScoopInstaller#4571 @niheaven
- ScoopInstaller#3244 @nickbudi
- ScoopInstaller#3821 @jfastnacht Co-authored-by: @rasa
- ScoopInstaller#4578 @tukanos
- ScoopInstaller#4579 @rashil2000

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com>
Co-authored-by: Ross Smith II <ross@smithii.com>
Co-authored-by: Benedikt Reinartz <filmor@gmail.com>
Co-authored-by: Joris <MrNuggelz@users.noreply.github.com>
Co-authored-by: Pratik Chowdhury <pratikc@live.co.uk>
Co-authored-by: Rashil Gandhi <rashil2000@gmail.com>
Co-authored-by: nickbudi <nickbudi@users.noreply.github.com>
Co-authored-by: Julian <github@fastnacht.consulting>
Co-authored-by: tukanos <patrik.svestka@gmail.com>
@rasa
Copy link
Copy Markdown
Member

rasa commented Mar 31, 2022

Making the description, homepage and license properties required, has caused hundreds of outside manifests to fail validation. For internal buckets, we can certainly require these fields, but they not are required for scoop to operate correctly.

At the very least, I like us to consider making the description field optional. Thoughts?

@niheaven
Copy link
Copy Markdown
Member Author

niheaven commented Apr 1, 2022

So the only field that make scoop workable is version, right? Now url or arch.url and hashes are required, too, but the schema cannot properly check it.

I'll remove description and keep homepage and license since they are essential for an app, and could discuss if removing these two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants