Skip to content

feat(config): Allow Scoop to ignore running processes during reset/uninstall/update #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niheaven merged 8 commits into from
Feb 11, 2022
Merged

feat(config): Allow Scoop to ignore running processes during reset/uninstall/update #4713

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
55eb57d
Prompt user to proceed uninstaller script if process is still running
CrendKing Feb 3, 2022
479dd59
New requirements
CrendKing Feb 9, 2022
cf2303a
Move the function to install.ps1
CrendKing Feb 9, 2022
fa011e9
Update accroding to rashil2000's comment
CrendKing Feb 9, 2022
284c0b6
Address comments
CrendKing Feb 11, 2022
e7be70d
Update CHANGELOG
CrendKing Feb 11, 2022
c0374a3
Merge branch 'develop' into running-uninst-prompt
niheaven Feb 11, 2022
e55639d
Code refactor
niheaven Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libexec/scoop-reset.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ $apps | ForEach-Object {

#region Workaround for #2952
$processdir = $dir | Select-Object -ExpandProperty Path
if (Get-Process | Where-Object { $_.Path -like "$processdir\*" }) {
if ((Get-Process | Where-Object { $_.Path -like "$processdir\*" }) -and
(Read-Host "Application '$app' is still running. Do you want to proceed uninstallation? All unsaved data will be lost [y/N]") -ne 'y') {
Comment thread
rashil2000 marked this conversation as resolved.
Outdated
error "Application is still running. Close all instances and try again."
continue
}
Expand Down
3 changes: 2 additions & 1 deletion libexec/scoop-uninstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ if (!$apps) { exit 0 }

#region Workaround for #2952
$processdir = $appDir | Resolve-Path | Select-Object -ExpandProperty Path
if (Get-Process | Where-Object { $_.Path -like "$processdir\*" }) {
if ((Get-Process | Where-Object { $_.Path -like "$processdir\*" }) -and
(Read-Host "Application '$app' is still running. Do you want to proceed uninstallation? All unsaved data will be lost [y/N]") -ne 'y') {
Comment thread
rashil2000 marked this conversation as resolved.
Outdated
error 'Application is still running. Close all instances and try again.'
continue
}
Expand Down
3 changes: 2 additions & 1 deletion libexec/scoop-update.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@ function update($app, $global, $quiet = $false, $independent, $suggested, $use_c

#region Workaround for #2952
$processdir = appdir $app $global | Resolve-Path | Select-Object -ExpandProperty Path
if (Get-Process | Where-Object { $_.Path -like "$processdir\*" }) {
if ((Get-Process | Where-Object { $_.Path -like "$processdir\*" }) -and
(Read-Host "Application '$app' is still running. Do you want to proceed uninstallation? All unsaved data will be lost [y/N]") -ne 'y') {
Comment thread
rashil2000 marked this conversation as resolved.
Outdated
error "Application is still running. Close all instances and try again."
return
}
Expand Down
⚡