Skip to content

fix(cleanup): Hotfix for #4681 #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niheaven merged 2 commits into from
Feb 26, 2022
Merged

fix(cleanup): Hotfix for #4681 #4763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25f25b4
fix(cleanup): Hotfix for #4681
niheaven Feb 26, 2022
2be4a4b
docs(changelog): Update CHANGELOG
niheaven Feb 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

### Performance Improvements

- **uninstall:** Avoid checking all files for unlinking persisted data ([#4681](https://github.com/ScoopInstaller/Scoop/issues/4681))
- **uninstall:** Avoid checking all files for unlinking persisted data ([#4681](https://github.com/ScoopInstaller/Scoop/issues/4681), [#4763](https://github.com/ScoopInstaller/Scoop/issues/4763))

### Code Refactoring

Expand Down
2 changes: 1 addition & 1 deletion libexec/scoop-cleanup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function cleanup($app, $global, $verbose, $cache) {
Write-Host " $version" -NoNewline
$dir = versiondir $app $version $global
# unlink all potential old link before doing recursive Remove-Item
unlink_persist_data $manifest $dir
unlink_persist_data (installed_manifest $app $version $global) $dir
Remove-Item $dir -ErrorAction Stop -Recurse -Force
}
$leftVersions = Get-ChildItem $appDir
Expand Down
⚡