Skip to content

fix(scoop-download): Add failure check #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rashil2000 merged 3 commits into from
Mar 18, 2022
Merged

fix(scoop-download): Add failure check #4822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4427be1
scoop-download failure check, aria2 warn if uninstalled
tech189 Mar 17, 2022
c86de52
Revert core.ps1
tech189 Mar 17, 2022
1deb259
Update CHANGELOG.md
tech189 Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- **installed:** If no `$global`, check both local and global installed ([#4798](https://github.com/ScoopInstaller/Scoop/issues/4798))
- **scoop-prefix:** Fix typo that breaks global installed apps ([#4795](https://github.com/ScoopInstaller/Scoop/issues/4795))
- **update:** Skip logs starting with `(chore)` ([#4800](https://github.com/ScoopInstaller/Scoop/issues/4800))
- **scoop-download:** Add failure check ([#4822](https://github.com/ScoopInstaller/Scoop/pull/4822))

### Code Refactoring

Expand Down
5 changes: 4 additions & 1 deletion libexec/scoop-download.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ foreach ($curr_app in $apps) {
} catch {
write-host -f darkred $_
error "URL $url is not valid"
$dl_failure = $true
continue
}

Expand All @@ -124,7 +125,9 @@ foreach ($curr_app in $apps) {
}
}

success "'$app' ($version) was downloaded successfully!"
if (!$dl_failure) {
success "'$app' ($version) was downloaded successfully!"
}
}

exit 0
⚡