Skip to content

feat(install): Show the running process #5102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rashil2000 merged 5 commits into from
Aug 15, 2022
Merged

feat(install): Show the running process #5102

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b9a1a4
feat(install): show the running process
yi-Xu-0100 Aug 13, 2022
cf00ee9
docs(CHANGELOG): Update changelog
yi-Xu-0100 Aug 13, 2022
b98611b
perf(install): Show process-name in table format
yi-Xu-0100 Aug 13, 2022
2ef2b0f
Update lib/install.ps1
yi-Xu-0100 Aug 15, 2022
80e4ffd
Update lib/install.ps1
yi-Xu-0100 Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- **scoop-(un)hold:** Support `scoop (un)hold scoop` ([#5089](https://github.com/ScoopInstaller/Scoop/issues/5089))
- **scoop-update:** Stash uncommitted changes before update ([#5091](https://github.com/ScoopInstaller/Scoop/issues/5091))
- **install:** Show the running process ([#5102](https://github.com/ScoopInstaller/Scoop/issues/5102))

## [v0.2.4](https://github.com/ScoopInstaller/Scoop/compare/v0.2.3...v0.2.4) - 2022-08-08

Expand Down
4 changes: 3 additions & 1 deletion lib/install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,14 +1231,16 @@ function persist_permission($manifest, $global) {
# test if there are running processes
function test_running_process($app, $global) {
$processdir = appdir $app $global | Convert-Path
$running_processes = Get-Process | Where-Object { $_.Path -like "$processdir\*" }
$running_processes = Get-Process | Where-Object { $_.Path -like "$processdir\*" } | Out-String

if ($running_processes) {
if (get_config 'ignore_running_processes') {
warn "Application `"$app`" is still running. Scoop is configured to ignore this condition."
warn "running_processes: $running_processes"
Comment thread
yi-Xu-0100 marked this conversation as resolved.
Outdated
return $false
} else {
error "Application `"$app`" is still running. Close all instances and try again."
error "running_processes: $running_processes"
Comment thread
yi-Xu-0100 marked this conversation as resolved.
Outdated
return $true
}
} else {
Expand Down
⚡