fix(config): Change config option to snake_case in file and SCREAMING_CASE in code#5116
Merged
fix(config): Change config option to snake_case in file and SCREAMING_CASE in code#5116
Conversation
r15ch13
previously approved these changes
Aug 20, 2022
Signed-off-by: Hsiao-nan Cheung <niheaven@gmail.com>
r15ch13
previously approved these changes
Aug 21, 2022
This was introduced in #4644 and only occurred in non-Unicode system
This was referenced Aug 23, 2022
1 task
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use snake_case in
~/.config/scoop.jsonand CREAMING_CASE in Scoop code for config options.Also change some config options' name:
Motivation and Context
How Has This Been Tested?
NOTICE If someone want to test this PR, please backup
~/.config/scoop.json😄Local tests (
.\bin\test.ps1) passed, andscoop configgives a warning if use old names. (BTW, PowerShell is case insensitive)Checklist:
developbranch.