feat(install): Add support for ARM64 architecture#5154
Merged
rashil2000 merged 8 commits intodevelopfrom Sep 27, 2022
Merged
Conversation
Member
Author
|
Stuff remaining:
Food for thought: Should we compile and add different shim binaries for different architectures? That is, |
Member
Author
|
7zip ships an MSI installer for x86 and x64 archs, but only a self-extracting executable for ARM64. We would need to request ipavlov to provide an MSI installer which Scoop can use in the 7zip manifest. See https://sourceforge.net/p/sevenzip/support-requests/431. |
- Move `default_architecture()` to `core.ps1`
Member
|
Make some changes:
Testing manifests are pushed to |
1 task
rashil2000
commented
Sep 26, 2022
Member
|
@rashil2000 I've test it and LGTM, any comments? |
pynappo
pushed a commit
to pynappo/Scoop
that referenced
this pull request
Sep 29, 2022
* Initial support for ARMv8 * Add fallback mechanism * Update changelog * Update useragent * Some typo and format changes * Use `env:ProgramFiles(Arm)` to detect ARM64 - Move `default_architecture()` to `core.ps1` * Rename 'ensure_architecture()' and 'default_architecture()' * Refactor 'supports_architecture()' to 'Get-SupportedArchitecture()' Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
5 tasks
r15ch13
reviewed
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables installing ARMv8 apps
Motivation and Context
Closes #3146
Supercedes #4071
How Has This Been Tested?
First fzf is from main bucket. Second fzf is a modified version, as follows:
{ "version": "0.33.0", "description": "A general-purpose command-line fuzzy finder", "homepage": "https://github.com/junegunn/fzf", "license": "MIT", "architecture": { "64bit": { "url": "https://github.com/junegunn/fzf/releases/download/0.33.0/fzf-0.33.0-windows_amd64.zip", "hash": "f2ddd0ce44f2ebd52009c0f36d99270d711234a605529e01fd97fef87223fd1e" }, "arm64": { "url": "https://github.com/junegunn/fzf/releases/download/0.33.0/fzf-0.33.0-windows_arm64.zip", "hash": "ff222c81fda88f42b6893216c4a63b733680741d439fb9a67ac2d1a00ab03065" } }, "bin": "fzf.exe", "checkver": "github", "autoupdate": { "architecture": { "64bit": { "url": "https://github.com/junegunn/fzf/releases/download/$version/fzf-$version-windows_amd64.zip" }, "arm64": { "url": "https://github.com/junegunn/fzf/releases/download/$version/fzf-$version-windows_arm64.zip" } } } }Checklist:
developbranch.