Skip to content

fix(tests): Fix tests in Linux and macOS #5179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niheaven merged 9 commits into from
Oct 15, 2022
Merged

fix(tests): Fix tests in Linux and macOS #5179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e0cc5df
Skip decompress tests
niheaven Sep 24, 2022
2f2aa7e
Pass all non-skipped tests
niheaven Oct 7, 2022
5fc99a3
Remove unused codes
niheaven Oct 10, 2022
c98870e
Use 'ExcludeTag' instead of '-Skip'
niheaven Oct 10, 2022
fc1bb0a
Merge branch 'develop' into fix-test-in-unix
niheaven Oct 13, 2022
aab6c3d
Use PS's default 'Expand-Archive()'
niheaven Oct 14, 2022
527d28b
docs(chglog): Update CHANGELOG
niheaven Oct 14, 2022
690a4ab
Minor tweaks
niheaven Oct 14, 2022
597c7d0
Separate PR
niheaven Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/decompress.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ function Expand-ZipArchive {
$OriDestinationPath = $DestinationPath
$DestinationPath = "$DestinationPath\_tmp"
}
Expand-Archive -Path $Path -DestinationPath $DestinationPath -Force
Microsoft.PowerShell.Archive\Expand-Archive -Path $Path -DestinationPath $DestinationPath -Force
Comment thread
niheaven marked this conversation as resolved.
Outdated
if ($ExtractDir) {
movedir "$DestinationPath\$ExtractDir" $OriDestinationPath | Out-Null
Remove-Item $DestinationPath -Recurse -Force
Expand Down
2 changes: 1 addition & 1 deletion test/Scoop-Decompress.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Describe 'Decompression function' -Tag 'Scoop', 'Decompress' {
(Get-FileHash -Path $testcases -Algorithm SHA256).Hash.ToLower() | Should -Be '791bfce192917a2ff225dcdd87d23ae5f720b20178d85e68e4b1b56139cf8e6a'
}
It 'Test cases should be extracted correctly' {
{ Expand-Archive -Path $testcases -DestinationPath $working_dir } | Should -Not -Throw
{ Microsoft.PowerShell.Archive\Expand-Archive -Path $testcases -DestinationPath $working_dir } | Should -Not -Throw
}
}

Expand Down
⚡