Fix HTTP status code modification while exception handling (#2027)#2028
Open
tanakahisateru wants to merge 1 commit intoSeldaek:mainfrom
Open
Fix HTTP status code modification while exception handling (#2027)#2028tanakahisateru wants to merge 1 commit intoSeldaek:mainfrom
tanakahisateru wants to merge 1 commit intoSeldaek:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2027
The
headers_sent()guard does not prevent theE_WARNINGfromhttp_response_code(). The warning is emitted whenheader('HTTP/...')has already been called, butheaders_sent()only becomestrueafter output is flushed to the stream — these are independent states.headers_list()might seem like an alternative to detect a previously set status line, but it intentionally excludes the HTTP status line.Dropping the
headers_sent()check and suppressing the warning with@is the most correct approach available: it sets 500 when possible and silently does nothing when it cannot.