Skip to content

[rb] upgrade to steep 2.0#17470

Merged
titusfortner merged 1 commit into
trunkfrom
steep
May 15, 2026
Merged

[rb] upgrade to steep 2.0#17470
titusfortner merged 1 commit into
trunkfrom
steep

Conversation

@titusfortner

Copy link
Copy Markdown
Member

Steep 2 allows us to remove activesupport dependency which is nice
This ran ./go rb:update and ./go rb:lint to verify everything is good.

@selenium-ci selenium-ci added C-rb Ruby Bindings B-build Includes scripting, bazel and CI integrations labels May 15, 2026
@qodo-code-review

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Upgrade Steep to 2.0 and remove ActiveSupport dependency

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Upgrade Steep from 1.10.0 to 2.0.0 for improved type checking
• Remove ActiveSupport dependency no longer needed by Steep 2.0
• Remove unnecessary gems: benchmark, connection_pool, drb, i18n, minitest, mutex_m, tzinfo
• Update RBS to 4.0.2 and logger RBS source to git-based collection
• Update Rubocop to 1.86.2 for compatibility
Diagram
flowchart LR
  A["Steep 1.10.0"] -- "upgrade" --> B["Steep 2.0.0"]
  C["ActiveSupport 7.2.3"] -- "remove" --> D["Removed"]
  E["RBS 3.10.4"] -- "upgrade" --> F["RBS 4.0.2"]
  B -- "enables" --> G["Cleaner dependencies"]
Loading

Grey Divider

File Changes

1. MODULE.bazel Dependencies +3/-11

Update Steep 2.0 and remove unnecessary dependencies

• Updated Steep from 1.10.0 to 2.0.0 with new checksum
• Removed ActiveSupport 7.2.3 gem dependency
• Removed benchmark, connection_pool, drb, i18n, minitest, mutex_m, and tzinfo gems
• Updated RBS from 3.10.4 to 4.0.2
• Updated Rubocop from 1.86.1 to 1.86.2

MODULE.bazel


2. rb/Gemfile Dependencies +1/-3

Update Steep and remove ActiveSupport dependency

• Removed ActiveSupport gem dependency with version constraint ~> 7.0
• Updated Steep gem from ~> 1.10.0 to ~> 2.0
• Removed comment about ActiveSupport 8.x Ruby version requirement

rb/Gemfile


3. rb/rbs_collection.lock.yaml ⚙️ Configuration changes +6/-2

Update logger RBS source and version

• Updated logger RBS source from stdlib to git-based gem_rbs_collection
• Changed logger version from '0' to '1.7'
• Updated gem_rbs_collection revision reference

rb/rbs_collection.lock.yaml


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@titusfortner titusfortner merged commit 47f2528 into trunk May 15, 2026
43 checks passed
@titusfortner titusfortner deleted the steep branch May 15, 2026 21:45
This was referenced Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations C-rb Ruby Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants